[Offlining] Updates the tab helper to use the async OfflinePageModel API

chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/offline_page_tab_helper.h"
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/feature_list.h"
 #include "base/files/file_path.h"
 #include "base/memory/weak_ptr.h"
 #include "base/run_loop.h"
+#include "base/test/histogram_tester.h"
 #include "chrome/browser/android/offline_pages/offline_page_model_factory.h"
 #include "chrome/browser/android/offline_pages/test_offline_page_model_builder.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "components/offline_pages/client_namespace_constants.h"
 #include "components/offline_pages/offline_page_feature.h"
 #include "components/offline_pages/offline_page_item.h"
 #include "components/offline_pages/offline_page_model.h"
 #include "components/offline_pages/offline_page_test_archiver.h"
 #include "components/offline_pages/offline_page_types.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/web_contents.h"
 #include "net/base/net_errors.h"
 #include "net/base/network_change_notifier.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace offline_pages {
 
 namespace {
 
 const GURL kTestPageUrl("http://test.org/page1");
 const ClientId kTestClientId = ClientId(kBookmarkNamespace, "1234");
 const int64_t kTestFileSize = 876543LL;
+const char kBadNetworkHistogram[] =
+    "OfflinePages.ShowOfflinePageOnBadNetwork";
+const char kRedirectToOfflineHistogram[] =
+    "OfflinePages.RedirectToOfflineCount";
+const char kRedirectToOnlineHistogram[] =
+    "OfflinePages.RedirectToOnlineCount";
 
 class TestNetworkChangeNotifier : public net::NetworkChangeNotifier {
  public:
   TestNetworkChangeNotifier() : online_(true) {}
 
   net::NetworkChangeNotifier::ConnectionType GetCurrentConnectionType()
       const override {
     return online_ ? net::NetworkChangeNotifier::CONNECTION_UNKNOWN
                    : net::NetworkChangeNotifier::CONNECTION_NONE;
   }
@@ skipping 25 matching lines @@
   void StartLoad(const GURL& url);
   void FailLoad(const GURL& url);
 
   OfflinePageTabHelper* offline_page_tab_helper() const {
     return offline_page_tab_helper_;
   }
 
   const GURL& online_url() const { return online_url_; }
   const GURL& offline_url() const { return offline_url_; }
 
+  const base::HistogramTester& histograms() const { return histogram_tester_; }
+
  private:
   // OfflinePageTestArchiver::Observer implementation:
   void SetLastPathCreatedByArchiver(const base::FilePath& file_path) override;
 
   std::unique_ptr<OfflinePageTestArchiver> BuildArchiver(
       const GURL& url,
       const base::FilePath& file_name);
   void OnSavePageDone(SavePageResult result, int64_t offline_id);
   void OnGetPageByOfflineIdDone(const SingleOfflinePageItemResult& result);
 
   std::unique_ptr<TestNetworkChangeNotifier> network_change_notifier_;
   OfflinePageTabHelper* offline_page_tab_helper_;  // Not owned.
 
   GURL online_url_;
   GURL offline_url_;
 
+  base::HistogramTester histogram_tester_;
+
   DISALLOW_COPY_AND_ASSIGN(OfflinePageTabHelperTest);
 };
 
 void OfflinePageTabHelperTest::SetUp() {
   // Enables offline pages feature.
   // TODO(jianli): Remove this once the feature is completely enabled.
   base::FeatureList::ClearInstanceForTesting();
   std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
   feature_list->InitializeFromCommandLine(
       offline_pages::kOfflineBookmarksFeature.name, "");
@@ skipping 82 matching lines @@
 }
 
 TEST_F(OfflinePageTabHelperTest, SwitchToOnlineFromOfflineOnNetwork) {
   SimulateHasNetworkConnectivity(true);
 
   StartLoad(offline_url());
   // Gives a chance to run delayed task to do redirection.
   RunUntilIdle();
   // Redirection will be done immediately on navigation start.
   EXPECT_EQ(online_url(), controller().GetPendingEntry()->GetURL());
+  histograms().ExpectTotalCount(kBadNetworkHistogram, 0);
+  histograms().ExpectTotalCount(kRedirectToOfflineHistogram, 0);
+  histograms().ExpectTotalCount(kRedirectToOnlineHistogram, 1);
 }
 
 TEST_F(OfflinePageTabHelperTest, SwitchToOfflineFromOnlineOnNoNetwork) {
   SimulateHasNetworkConnectivity(false);
 
   StartLoad(online_url());
   // Gives a chance to run delayed task to do redirection.
   RunUntilIdle();
   // Redirection will be done immediately on navigation start.
   EXPECT_EQ(offline_url(), controller().GetPendingEntry()->GetURL());
+  histograms().ExpectTotalCount(kBadNetworkHistogram, 0);
+  histograms().ExpectTotalCount(kRedirectToOfflineHistogram, 1);
+  histograms().ExpectTotalCount(kRedirectToOnlineHistogram, 0);
 }
 
 TEST_F(OfflinePageTabHelperTest, SwitchToOfflineFromOnlineOnError) {
   SimulateHasNetworkConnectivity(true);
 
   StartLoad(online_url());
   RunUntilIdle();
   EXPECT_EQ(online_url(), controller().GetPendingEntry()->GetURL());
 
   // Redirection will be done immediately on navigation end with error.
   FailLoad(online_url());
   EXPECT_EQ(offline_url(), controller().GetPendingEntry()->GetURL());
+
+  histograms().ExpectBucketCount(kBadNetworkHistogram, false, 0);
+  histograms().ExpectBucketCount(kBadNetworkHistogram, true, 1);
+  histograms().ExpectTotalCount(kRedirectToOfflineHistogram, 1);
+  histograms().ExpectTotalCount(kRedirectToOnlineHistogram, 0);
 }
 
+TEST_F(OfflinePageTabHelperTest, NewNavigationCancelsPendingRedirects) {
+  SimulateHasNetworkConnectivity(false);
+
+  StartLoad(online_url());
+  const GURL unsaved_url("http://test.org/page2");
+
+  // We should have a pending task that will do the redirect.
+  ASSERT_TRUE(offline_page_tab_helper()->weak_ptr_factory_.HasWeakPtrs());
+  ASSERT_EQ(online_url(), controller().GetPendingEntry()->GetURL());
+
+  // Should cancel pending tasks for previous URL.
+  StartLoad(unsaved_url);
+
+  // Gives a chance to run delayed task to do redirection.
+  RunUntilIdle();
+
+  // Redirection should be cancelled so we should still navigate to
+  // |unsaved_url|.
+  EXPECT_EQ(unsaved_url, controller().GetPendingEntry()->GetURL());
+
+  histograms().ExpectTotalCount(kBadNetworkHistogram, 0);
+  histograms().ExpectTotalCount(kRedirectToOfflineHistogram, 0);
+  histograms().ExpectTotalCount(kRedirectToOnlineHistogram, 0);
+}
 }  // namespace offline_pages