third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp - Issue 2040563002: Remove FileError interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp

Issue 2040563002: Remove FileError interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fe-dep

Patch Set: Review feedback Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h ('k') | third_party/WebKit/Source/modules/filesystem/FileWriter.h » ('j') | third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp

diff --git a/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp b/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp

index b88517d57b02c90ab6f93b61a61eb835ad138b49..6ad946a7b173e9de25a0533680ed891def5d671b 100644

--- a/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp

+++ b/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp

@@ -72,7 +72,7 @@ FileSystemCallbacksBase::~FileSystemCallbacksBase()

void FileSystemCallbacksBase::didFail(int code)

{

if (m_errorCallback)

- handleEventOrScheduleCallback(m_errorCallback.release(), FileError::create(static_cast<FileError::ErrorCode>(code)));

+ handleEventOrScheduleCallback(m_errorCallback.release(), static_cast<FileError::ErrorCode>(code));

}

bool FileSystemCallbacksBase::shouldScheduleCallback() const

@@ -81,7 +81,7 @@ bool FileSystemCallbacksBase::shouldScheduleCallback() const

}

template <typename CB, typename CBArg>

-void FileSystemCallbacksBase::handleEventOrScheduleCallback(CB* callback, CBArg* arg)

+void FileSystemCallbacksBase::handleEventOrScheduleCallback(CB* callback, CBArg arg)

{

ASSERT(callback);

if (shouldScheduleCallback())

@@ -201,7 +201,7 @@ void ResolveURICallbacks::didResolveURL(const String& name, const KURL& rootURL,

String absolutePath;

if (!DOMFileSystemBase::pathToAbsolutePath(type, root, filePath, absolutePath)) {

- handleEventOrScheduleCallback(m_errorCallback.release(), FileError::create(FileError::INVALID_MODIFICATION_ERR));

+ handleEventOrScheduleCallback(m_errorCallback.release(), FileError::INVALID_MODIFICATION_ERR);

return;

}