Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp

Issue 2040563002: Remove FileError interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fe-dep
Patch Set: Review feedback Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp
diff --git a/third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp b/third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp
index c5f2012cc7b0b6664044ca5e80a323b8378ed42f..2ec157e157a049461481686fa512bff1c88b24f0 100644
--- a/third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp
+++ b/third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp
@@ -63,7 +63,7 @@ DOMFileSystemSync::~DOMFileSystemSync()
{
}
-void DOMFileSystemSync::reportError(ErrorCallback* errorCallback, FileError* fileError)
+void DOMFileSystemSync::reportError(ErrorCallback* errorCallback, FileError::ErrorCode fileError)
{
errorCallback->handleEvent(fileError);
}
@@ -186,10 +186,15 @@ public:
return new LocalErrorCallback(errorCode);
}
- void handleEvent(FileError* error) override
+ void handleEvent(DOMException* error) override
{
- ASSERT(error->code() != FileError::OK);
- m_errorCode = error->code();
+ NOTREACHED();
+ }
+
+ void handleEvent(FileError::ErrorCode error) override
+ {
+ DCHECK_NE(error, FileError::OK);
+ m_errorCode = error;
}
private:

Powered by Google App Engine
This is Rietveld 408576698