third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp - Issue 2040563002: Remove FileError interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp

Issue 2040563002: Remove FileError interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fe-dep

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp

diff --git a/third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp b/third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp

index c5f2012cc7b0b6664044ca5e80a323b8378ed42f..eb40450302aa56ec86c4780b51b6d15a6e5e255b 100644

--- a/third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp

+++ b/third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp

@@ -186,6 +186,11 @@ public:

return new LocalErrorCallback(errorCode);

}

+ void handleEvent(DOMException* error) override

jsbell 2016/06/03 21:41:58 This pattern is repeated. I wasn't sure if having

+ {

+ NOTREACHED();

+ }

void handleEvent(FileError* error) override

{

ASSERT(error->code() != FileError::OK);