Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp

Issue 2040563002: Remove FileError interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fe-dep
Patch Set: Rebased, and closure annotations Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 ASSERT(m_numberOfPendingCallbacks > 0); 108 ASSERT(m_numberOfPendingCallbacks > 0);
109 --m_numberOfPendingCallbacks; 109 --m_numberOfPendingCallbacks;
110 } 110 }
111 111
112 bool DOMFileSystem::hasPendingActivity() const 112 bool DOMFileSystem::hasPendingActivity() const
113 { 113 {
114 ASSERT(m_numberOfPendingCallbacks >= 0); 114 ASSERT(m_numberOfPendingCallbacks >= 0);
115 return m_numberOfPendingCallbacks; 115 return m_numberOfPendingCallbacks;
116 } 116 }
117 117
118 void DOMFileSystem::reportError(ErrorCallback* errorCallback, FileError* fileErr or) 118 void DOMFileSystem::reportError(ErrorCallback* errorCallback, FileError::ErrorCo de fileError)
119 { 119 {
120 scheduleCallback(errorCallback, fileError); 120 scheduleCallback(errorCallback, fileError);
121 } 121 }
122 122
123 namespace { 123 namespace {
124 124
125 class ConvertToFileWriterCallback : public FileWriterBaseCallback { 125 class ConvertToFileWriterCallback : public FileWriterBaseCallback {
126 public: 126 public:
127 static ConvertToFileWriterCallback* create(FileWriterCallback* callback) 127 static ConvertToFileWriterCallback* create(FileWriterCallback* callback)
128 { 128 {
(...skipping 18 matching lines...) Expand all
147 Member<FileWriterCallback> m_callback; 147 Member<FileWriterCallback> m_callback;
148 }; 148 };
149 149
150 } // namespace 150 } // namespace
151 151
152 void DOMFileSystem::createWriter(const FileEntry* fileEntry, FileWriterCallback* successCallback, ErrorCallback* errorCallback) 152 void DOMFileSystem::createWriter(const FileEntry* fileEntry, FileWriterCallback* successCallback, ErrorCallback* errorCallback)
153 { 153 {
154 ASSERT(fileEntry); 154 ASSERT(fileEntry);
155 155
156 if (!fileSystem()) { 156 if (!fileSystem()) {
157 reportError(errorCallback, FileError::create(FileError::ABORT_ERR)); 157 reportError(errorCallback, FileError::ABORT_ERR);
158 return; 158 return;
159 } 159 }
160 160
161 FileWriter* fileWriter = FileWriter::create(getExecutionContext()); 161 FileWriter* fileWriter = FileWriter::create(getExecutionContext());
162 FileWriterBaseCallback* conversionCallback = ConvertToFileWriterCallback::cr eate(successCallback); 162 FileWriterBaseCallback* conversionCallback = ConvertToFileWriterCallback::cr eate(successCallback);
163 std::unique_ptr<AsyncFileSystemCallbacks> callbacks = FileWriterBaseCallback s::create(fileWriter, conversionCallback, errorCallback, m_context); 163 std::unique_ptr<AsyncFileSystemCallbacks> callbacks = FileWriterBaseCallback s::create(fileWriter, conversionCallback, errorCallback, m_context);
164 fileSystem()->createFileWriter(createFileSystemURL(fileEntry), fileWriter, s td::move(callbacks)); 164 fileSystem()->createFileWriter(createFileSystemURL(fileEntry), fileWriter, s td::move(callbacks));
165 } 165 }
166 166
167 void DOMFileSystem::createFile(const FileEntry* fileEntry, BlobCallback* success Callback, ErrorCallback* errorCallback) 167 void DOMFileSystem::createFile(const FileEntry* fileEntry, BlobCallback* success Callback, ErrorCallback* errorCallback)
168 { 168 {
169 KURL fileSystemURL = createFileSystemURL(fileEntry); 169 KURL fileSystemURL = createFileSystemURL(fileEntry);
170 if (!fileSystem()) { 170 if (!fileSystem()) {
171 reportError(errorCallback, FileError::create(FileError::ABORT_ERR)); 171 reportError(errorCallback, FileError::ABORT_ERR);
172 return; 172 return;
173 } 173 }
174 174
175 fileSystem()->createSnapshotFileAndReadMetadata(fileSystemURL, SnapshotFileC allback::create(this, fileEntry->name(), fileSystemURL, successCallback, errorCa llback, m_context)); 175 fileSystem()->createSnapshotFileAndReadMetadata(fileSystemURL, SnapshotFileC allback::create(this, fileEntry->name(), fileSystemURL, successCallback, errorCa llback, m_context));
176 } 176 }
177 177
178 DEFINE_TRACE(DOMFileSystem) 178 DEFINE_TRACE(DOMFileSystem)
179 { 179 {
180 DOMFileSystemBase::trace(visitor); 180 DOMFileSystemBase::trace(visitor);
181 ActiveDOMObject::trace(visitor); 181 ActiveDOMObject::trace(visitor);
182 visitor->trace(m_rootEntry); 182 visitor->trace(m_rootEntry);
183 } 183 }
184 184
185 } // namespace blink 185 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698