Remove FileError interface

third_party/WebKit/Source/core/fileapi/FileError.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "core/fileapi/FileError.h"
 
 #include "bindings/core/v8/ExceptionState.h"
+#include "core/dom/DOMException.h"
 #include "core/dom/ExceptionCode.h"
 
 namespace blink {
 
 const char FileError::abortErrorMessage[] = "An ongoing operation was aborted, typically with a call to abort().";
 const char FileError::encodingErrorMessage[] = "A URI supplied to the API was malformed, or the resulting Data URL has exceeded the URL length limitations for Data URLs.";
 const char FileError::invalidStateErrorMessage[] = "An operation that depends on state cached in an interface object was made but the state had changed since it was read from disk.";
 const char FileError::noModificationAllowedErrorMessage[] = "An attempt was made to write to a file or directory which could not be modified due to the state of the underlying filesystem.";
 const char FileError::notFoundErrorMessage[] = "A requested file or directory could not be found at the time an operation was processed.";
 const char FileError::notReadableErrorMessage[] = "The requested file could not be read, typically due to permission problems that have occurred after a reference to a file was acquired.";
@@ skipping 85 matching lines @@
 
     // SecurityError is special-cased, as we want to route those exceptions through ExceptionState::throwSecurityError.
     if (code == FileError::SECURITY_ERR) {
         exceptionState.throwSecurityError(FileError::securityErrorMessage);
         return;
     }
 
     exceptionState.throwDOMException(errorCodeToExceptionCode(code), errorCodeToMessage(code));
 }
 
+DOMException* FileError::createDOMException(ErrorCode code)
+{
+    DCHECK_NE(code, FileError::OK);
+
+    // TODO(jsbell): Special case SecurityError?

[jsbell, 2016/06/03 21:41:58]

I believe this is safe as it's only used in places that would have minted
FileError/DOMError instances before with just the same information, and the
message is completely generic anyway.

I could remove the special case entirely.

+    if (code == FileError::SECURITY_ERR) {
+        return DOMException::create(SecurityError, FileError::securityErrorMessage);
+    }
+
+    return DOMException::create(errorCodeToExceptionCode(code), errorCodeToMessage(code));
+}
+
 FileError::FileError(ErrorCode code)
-    : DOMError(DOMException::getErrorName(errorCodeToExceptionCode(code)), errorCodeToMessage(code))
-    , m_code(code)
+    : m_code(code)
 {
 }
 
 } // namespace blink