Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1320)

Issue 2040553002: Remove unused constant history::kThumbnailsFilename. (Closed)

Created:
4 years, 6 months ago by Scott Hess - ex-Googler
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@zzzzsql_diagnostic_thumbnails
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused constant history::kThumbnailsFilename. The migration from Thumbnails to Favicons has been done for many years. BUG=617226 Committed: https://crrev.com/f06ded49f7565b24afc3005c395dc222774e6244 Cr-Commit-Position: refs/heads/master@{#397951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M components/history/core/browser/expire_history_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/history_backend.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/history/core/browser/history_backend.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M components/history/core/browser/history_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/history/core/browser/history_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
Scott Hess - ex-Googler
The diagnostics code was the last real user!
4 years, 6 months ago (2016-06-03 21:27:00 UTC) #2
Scott Hess - ex-Googler
On 2016/06/03 21:27:00, Scott Hess wrote: > The diagnostics code was the last real user! ...
4 years, 6 months ago (2016-06-03 21:27:15 UTC) #3
sky
LGTM
4 years, 6 months ago (2016-06-03 22:33:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040553002/1
4 years, 6 months ago (2016-06-05 20:29:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-05 21:39:27 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-05 21:41:05 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f06ded49f7565b24afc3005c395dc222774e6244
Cr-Commit-Position: refs/heads/master@{#397951}

Powered by Google App Engine
This is Rietveld 408576698