Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Unified Diff: cc/animation/animation_host_unittest.cc

Issue 2040543002: Take MT jank into account when animating the scroll offset on CC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add test + apply suggested improvement Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/animation/animation_host.cc ('k') | cc/animation/scroll_offset_animation_curve.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/animation/animation_host_unittest.cc
diff --git a/cc/animation/animation_host_unittest.cc b/cc/animation/animation_host_unittest.cc
index e23730f8de4593810e9bf0d5c7c4c8903d3f8b22..eb51bc5861bffa421004b15d13fee7b0d1400b83 100644
--- a/cc/animation/animation_host_unittest.cc
+++ b/cc/animation/animation_host_unittest.cc
@@ -87,7 +87,7 @@ TEST_F(AnimationHostTest, ImplOnlyScrollAnimationUpdateTargetIfDetached) {
gfx::ScrollOffset target_offset(0., 2.);
gfx::ScrollOffset current_offset(0., 1.);
host_impl_->ImplOnlyScrollAnimationCreate(element_id_, target_offset,
- current_offset);
+ current_offset, base::TimeDelta());
gfx::Vector2dF scroll_delta(0, 0.5);
gfx::ScrollOffset max_scroll_offset(0., 3.);
@@ -96,14 +96,14 @@ TEST_F(AnimationHostTest, ImplOnlyScrollAnimationUpdateTargetIfDetached) {
time += base::TimeDelta::FromSecondsD(0.1);
EXPECT_TRUE(host_impl_->ImplOnlyScrollAnimationUpdateTarget(
- element_id_, scroll_delta, max_scroll_offset, time));
+ element_id_, scroll_delta, max_scroll_offset, time, base::TimeDelta()));
// Detach all players from layers and timelines.
host_impl_->ClearTimelines();
time += base::TimeDelta::FromSecondsD(0.1);
EXPECT_FALSE(host_impl_->ImplOnlyScrollAnimationUpdateTarget(
- element_id_, scroll_delta, max_scroll_offset, time));
+ element_id_, scroll_delta, max_scroll_offset, time, base::TimeDelta()));
}
} // namespace
« no previous file with comments | « cc/animation/animation_host.cc ('k') | cc/animation/scroll_offset_animation_curve.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698