Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Side by Side Diff: cc/trees/layer_tree_host_impl.h

Issue 2040543002: Take MT jank into account when animating the scroll offset on CC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add test + apply suggested improvement Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/layers/viewport.cc ('k') | cc/trees/layer_tree_host_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_TREES_LAYER_TREE_HOST_IMPL_H_ 5 #ifndef CC_TREES_LAYER_TREE_HOST_IMPL_H_
6 #define CC_TREES_LAYER_TREE_HOST_IMPL_H_ 6 #define CC_TREES_LAYER_TREE_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <bitset> 10 #include <bitset>
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 void BindToClient(InputHandlerClient* client) override; 164 void BindToClient(InputHandlerClient* client) override;
165 InputHandler::ScrollStatus ScrollBegin( 165 InputHandler::ScrollStatus ScrollBegin(
166 ScrollState* scroll_state, 166 ScrollState* scroll_state,
167 InputHandler::ScrollInputType type) override; 167 InputHandler::ScrollInputType type) override;
168 InputHandler::ScrollStatus RootScrollBegin( 168 InputHandler::ScrollStatus RootScrollBegin(
169 ScrollState* scroll_state, 169 ScrollState* scroll_state,
170 InputHandler::ScrollInputType type) override; 170 InputHandler::ScrollInputType type) override;
171 ScrollStatus ScrollAnimatedBegin(const gfx::Point& viewport_point) override; 171 ScrollStatus ScrollAnimatedBegin(const gfx::Point& viewport_point) override;
172 InputHandler::ScrollStatus ScrollAnimated( 172 InputHandler::ScrollStatus ScrollAnimated(
173 const gfx::Point& viewport_point, 173 const gfx::Point& viewport_point,
174 const gfx::Vector2dF& scroll_delta) override; 174 const gfx::Vector2dF& scroll_delta,
175 base::TimeDelta delayed_by = base::TimeDelta()) override;
175 void ApplyScroll(ScrollNode* scroll_node, ScrollState* scroll_state); 176 void ApplyScroll(ScrollNode* scroll_node, ScrollState* scroll_state);
176 InputHandlerScrollResult ScrollBy(ScrollState* scroll_state) override; 177 InputHandlerScrollResult ScrollBy(ScrollState* scroll_state) override;
177 bool ScrollVerticallyByPage(const gfx::Point& viewport_point, 178 bool ScrollVerticallyByPage(const gfx::Point& viewport_point,
178 ScrollDirection direction) override; 179 ScrollDirection direction) override;
179 void RequestUpdateForSynchronousInputHandler() override; 180 void RequestUpdateForSynchronousInputHandler() override;
180 void SetSynchronousInputHandlerRootScrollOffset( 181 void SetSynchronousInputHandlerRootScrollOffset(
181 const gfx::ScrollOffset& root_offset) override; 182 const gfx::ScrollOffset& root_offset) override;
182 void ScrollEnd(ScrollState* scroll_state) override; 183 void ScrollEnd(ScrollState* scroll_state) override;
183 InputHandler::ScrollStatus FlingScrollBegin() override; 184 InputHandler::ScrollStatus FlingScrollBegin() override;
184 void MouseMoveAt(const gfx::Point& viewport_point) override; 185 void MouseMoveAt(const gfx::Point& viewport_point) override;
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
595 } 596 }
596 597
597 InputHandler::ScrollStatus TryScroll(const gfx::PointF& screen_space_point, 598 InputHandler::ScrollStatus TryScroll(const gfx::PointF& screen_space_point,
598 InputHandler::ScrollInputType type, 599 InputHandler::ScrollInputType type,
599 const ScrollTree& scroll_tree, 600 const ScrollTree& scroll_tree,
600 ScrollNode* scroll_node) const; 601 ScrollNode* scroll_node) const;
601 602
602 // Returns true if a scroll offset animation is created and false if we scroll 603 // Returns true if a scroll offset animation is created and false if we scroll
603 // by the desired amount without an animation. 604 // by the desired amount without an animation.
604 bool ScrollAnimationCreate(ScrollNode* scroll_node, 605 bool ScrollAnimationCreate(ScrollNode* scroll_node,
605 const gfx::Vector2dF& scroll_amount); 606 const gfx::Vector2dF& scroll_amount,
607 base::TimeDelta delayed_by);
606 608
607 void SetLayerTreeMutator(std::unique_ptr<LayerTreeMutator> mutator); 609 void SetLayerTreeMutator(std::unique_ptr<LayerTreeMutator> mutator);
608 LayerTreeMutator* mutator() { return mutator_.get(); } 610 LayerTreeMutator* mutator() { return mutator_.get(); }
609 611
610 void ClearCurrentlyScrollingLayerForTesting() { 612 void ClearCurrentlyScrollingLayerForTesting() {
611 ClearCurrentlyScrollingLayer(); 613 ClearCurrentlyScrollingLayer();
612 } 614 }
613 615
614 protected: 616 protected:
615 LayerTreeHostImpl( 617 LayerTreeHostImpl(
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
705 void ClearUIResources(); 707 void ClearUIResources();
706 708
707 void NotifySwapPromiseMonitorsOfSetNeedsRedraw(); 709 void NotifySwapPromiseMonitorsOfSetNeedsRedraw();
708 void NotifySwapPromiseMonitorsOfForwardingToMainThread(); 710 void NotifySwapPromiseMonitorsOfForwardingToMainThread();
709 711
710 void UpdateRootLayerStateForSynchronousInputHandler(); 712 void UpdateRootLayerStateForSynchronousInputHandler();
711 713
712 void ScrollAnimationAbort(LayerImpl* layer_impl); 714 void ScrollAnimationAbort(LayerImpl* layer_impl);
713 715
714 bool ScrollAnimationUpdateTarget(ScrollNode* scroll_node, 716 bool ScrollAnimationUpdateTarget(ScrollNode* scroll_node,
715 const gfx::Vector2dF& scroll_delta); 717 const gfx::Vector2dF& scroll_delta,
718 base::TimeDelta delayed_by);
716 719
717 void SetCompositorContextVisibility(bool is_visible); 720 void SetCompositorContextVisibility(bool is_visible);
718 void SetWorkerContextVisibility(bool is_visible); 721 void SetWorkerContextVisibility(bool is_visible);
719 722
720 using UIResourceMap = std::unordered_map<UIResourceId, UIResourceData>; 723 using UIResourceMap = std::unordered_map<UIResourceId, UIResourceData>;
721 UIResourceMap ui_resource_map_; 724 UIResourceMap ui_resource_map_;
722 725
723 // Resources that were evicted by EvictAllUIResources. Resources are removed 726 // Resources that were evicted by EvictAllUIResources. Resources are removed
724 // from this when they are touched by a create or destroy from the UI resource 727 // from this when they are touched by a create or destroy from the UI resource
725 // request queue. 728 // request queue.
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
853 856
854 std::unique_ptr<PendingTreeDurationHistogramTimer> 857 std::unique_ptr<PendingTreeDurationHistogramTimer>
855 pending_tree_duration_timer_; 858 pending_tree_duration_timer_;
856 859
857 DISALLOW_COPY_AND_ASSIGN(LayerTreeHostImpl); 860 DISALLOW_COPY_AND_ASSIGN(LayerTreeHostImpl);
858 }; 861 };
859 862
860 } // namespace cc 863 } // namespace cc
861 864
862 #endif // CC_TREES_LAYER_TREE_HOST_IMPL_H_ 865 #endif // CC_TREES_LAYER_TREE_HOST_IMPL_H_
OLDNEW
« no previous file with comments | « cc/layers/viewport.cc ('k') | cc/trees/layer_tree_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698