Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Issue 204053002: Fix pixel snapping of stacked sub-pixel composited layers (Closed)

Created:
6 years, 9 months ago by leviw_travelin_and_unemployed
Modified:
6 years, 9 months ago
Reviewers:
eae
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr.
Visibility:
Public.

Description

Fix pixel snapping of stacked sub-pixel composited layers Correcting placement and clipping of sub-pixel offset composited layers by properly adding the accumulated sub- pixel offset from composited parents. BUG=347521 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169495

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -7 lines) Patch
M LayoutTests/compositing/repaint/should-not-repaint-composited-styles-expected.txt View 3 chunks +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/sub-pixel/nested-sub-pixel-composited-layers.html View 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/fast/sub-pixel/nested-sub-pixel-composited-layers-expected.html View 1 chunk +25 lines, -0 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 4 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
leviw_travelin_and_unemployed
6 years, 9 months ago (2014-03-18 22:11:58 UTC) #1
eae
LGTM
6 years, 9 months ago (2014-03-18 22:19:37 UTC) #2
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-18 22:19:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/204053002/1
6 years, 9 months ago (2014-03-18 22:19:54 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 23:09:20 UTC) #5
Message was sent while issue was closed.
Change committed as 169495

Powered by Google App Engine
This is Rietveld 408576698