Improves computation of IAccessible2 Hypertext.

Improves computation of IAccessible2 Hypertext.

1. Ensures that children that are in a different subtree are included in IA2 Hypertext.
2. Stops exposing the value of a rich text control in IA2 Hypertext.
BUG=614570
TESTED=NVDA,browser test
R=dmazzoni@chromium.org

Committed: https://crrev.com/a4f893a3ca5cd9fd001938fb455f1e0cde2877a5
Cr-Commit-Position: refs/heads/master@{#398578}

[nektarios, 2016-06-03 19:42:52]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 19:43:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040523002/1

[commit-bot: I haz the power, 2016-06-03 20:38:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 20:38:29]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[dmazzoni, 2016-06-03 20:56:06]

lgtm

Could you add an iframe test too?

One of the existing iframe tests with aria-label on the iframe element would
demonstrate the issue you're fixing, right?

[chromium-reviews, 2016-06-03 21:18:16]

Yes Of course, good catch.
Added on two of the iframe tests.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2016-06-03 21:48:21]

Make sure to dump ia2 attributes in the test so we can see that it fixed
the issue.

On Fri, Jun 3, 2016 at 2:18 PM 'Nektarios Paisios' via Chromium-reviews <
chromium-reviews@chromium.org> wrote:

> Yes Of course, good catch.
> Added on two of the iframe tests.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2016-06-03 22:14:23]

Done.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2016-06-03 22:30:09]

awesome, lgtm when expectations are updated

[nektarios, 2016-06-06 14:37:04]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2016-06-06 14:37:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040523002/60001

[commit-bot: I haz the power, 2016-06-06 15:06:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 15:06:29]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nektarios, 2016-06-06 18:53:41]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-06 18:54:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040523002/80001

[commit-bot: I haz the power, 2016-06-06 19:07:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 19:07:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nektarios, 2016-06-06 19:58:14]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-06 19:59:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040523002/100001

[commit-bot: I haz the power, 2016-06-06 20:09:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 20:09:12]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[dmazzoni, 2016-06-06 22:24:34]

https://codereview.chromium.org/2040523002/diff/100001/content/browser/access...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/2040523002/diff/100001/content/browser/access...
content/browser/accessibility/browser_accessibility_win.cc:3581: child_id = -1;
Use a unique id instead. Every BrowserAccessibility has unique_id() and you can
use the static BrowserAccessibility::GetFromUniqueID() to retrieve it. Just
switch the meaning of the hyperlink id so it's a unique ID everywhere

[chromium-reviews, 2016-06-06 22:48:53]

Done.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nektarios, 2016-06-06 22:52:25]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-06 22:52:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040523002/140001

[commit-bot: I haz the power, 2016-06-06 23:21:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 23:21:56]

Dry run: Try jobs failed on following builders:
  win_clang on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[dmazzoni, 2016-06-07 15:45:54]

lgtm

https://codereview.chromium.org/2040523002/diff/140001/content/browser/access...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/2040523002/diff/140001/content/browser/access...
content/browser/accessibility/browser_accessibility_win.cc:3572: int32_t
child_id = child->unique_id();
Maybe call this child_unique_id

https://codereview.chromium.org/2040523002/diff/140001/content/browser/access...
File content/browser/accessibility/browser_accessibility_win.h (right):

https://codereview.chromium.org/2040523002/diff/140001/content/browser/access...
content/browser/accessibility/browser_accessibility_win.h:932: // TODO(nektar):
Replace object IDs with child indices.
Does this todo still apply? Unique ids seem fine

[chromium-reviews, 2016-06-07 19:05:47]

>
https://codereview.chromium.org/2040523002/diff/140001/content/browser/access...
> File content/browser/accessibility/browser_accessibility_win.cc (right):
>
>
https://codereview.chromium.org/2040523002/diff/140001/content/browser/access...
> content/browser/accessibility/browser_accessibility_win.cc:3572: int32_t
> child_id = child->unique_id();
> Maybe call this child_unique_id
>
Done.

>
https://codereview.chromium.org/2040523002/diff/140001/content/browser/access...
> File content/browser/accessibility/browser_accessibility_win.h (right):
>
>
https://codereview.chromium.org/2040523002/diff/140001/content/browser/access...
> content/browser/accessibility/browser_accessibility_win.h:932: //
> TODO(nektar): Replace object IDs with child indices.
> Does this todo still apply? Unique ids seem fine

Yes it does because in the IA2 Spec IA2 Hyperlinks are use both for 
Hypertext and for other things. We only implemented the Hypertext part. 
If we decide that hyperlinks are not essential for anything else, then 
IDs (even unique ones) are not needed. We could simply use child 
indices. It would be easier to look up hyperlinks. No map would be 
needed. Just a vector with text offsets.
I added more clarification to the TODO.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nektarios, 2016-06-07 19:09:29]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2016-06-07 19:09:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2040523002/#ps160001
(title: "Addressed last comments.")

[commit-bot: I haz the power, 2016-06-07 19:09:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040523002/160001

[commit-bot: I haz the power, 2016-06-07 21:25:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 21:25:30]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[nektarios, 2016-06-07 23:27:54]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2016-06-07 23:27:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2040523002/#ps180001
(title: "Fixed test expectations on Windows.")

[nektarios, 2016-06-07 23:28:13]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2016-06-07 23:28:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040523002/180001

[commit-bot: I haz the power, 2016-06-08 00:46:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 00:46:28]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nektarios, 2016-06-08 14:58:16]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2016-06-08 14:58:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2040523002/#ps200001
(title: "Fixed expectations on Windows for hopefully the last time.")

[commit-bot: I haz the power, 2016-06-08 14:58:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040523002/200001

[commit-bot: I haz the power, 2016-06-08 16:04:48]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-06-08 16:06:24]

Description was changed from

==========
Improves computation of IAccessible2 Hypertext.

1. Ensures that children that are in a different subtree are included in IA2
Hypertext.
2. Stops exposing the value of a rich text control in IA2 Hypertext.
BUG=614570
TESTED=NVDA,browser test
R=dmazzoni@chromium.org
==========

to

==========
Improves computation of IAccessible2 Hypertext.

1. Ensures that children that are in a different subtree are included in IA2
Hypertext.
2. Stops exposing the value of a rich text control in IA2 Hypertext.
BUG=614570
TESTED=NVDA,browser test
R=dmazzoni@chromium.org

Committed: https://crrev.com/a4f893a3ca5cd9fd001938fb455f1e0cde2877a5
Cr-Commit-Position: refs/heads/master@{#398578}
==========

[commit-bot: I haz the power, 2016-06-08 16:06:26]

Patchset 11 (id:??) landed as
https://crrev.com/a4f893a3ca5cd9fd001938fb455f1e0cde2877a5
Cr-Commit-Position: refs/heads/master@{#398578}