xfa/fwl/core/cfwl_widgetmgr.cpp - Issue 2040503002: Fix more bugs found by /analyze tool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/core/cfwl_widgetmgr.cpp

Issue 2040503002: Fix more bugs found by /analyze tool (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/core/cfwl_widgetmgr.cpp

diff --git a/xfa/fwl/core/cfwl_widgetmgr.cpp b/xfa/fwl/core/cfwl_widgetmgr.cpp

index 90d621477a5f50475e3446e1f458ca2aa26adeac..78d820636979c1dc6954bdbaeeda752ddfae8961 100644

--- a/xfa/fwl/core/cfwl_widgetmgr.cpp

+++ b/xfa/fwl/core/cfwl_widgetmgr.cpp

@@ -768,8 +768,7 @@ FX_BOOL CFWL_WidgetMgrDelegate::IsNeedRepaint(IFWL_Widget* pWidget,

FX_BOOL bOrginPtIntersectWidthDirty =

rtDirty.Contains(rtWidget.left, rtWidget.top);

static FWL_NEEDREPAINTHITDATA hitPoint[kNeedRepaintHitPoints];

- int32_t iSize = sizeof(FWL_NEEDREPAINTHITDATA);

- FXSYS_memset(hitPoint, 0, iSize);

+ FXSYS_memset(hitPoint, 0, sizeof(hitPoint));

FX_FLOAT fxPiece = rtWidget.width / kNeedRepaintHitPiece;

FX_FLOAT fyPiece = rtWidget.height / kNeedRepaintHitPiece;

hitPoint[2].hitPoint.x = hitPoint[6].hitPoint.x = rtWidget.left;

« no previous file with comments | « core/fpdfapi/fpdf_parser/cpdf_stream_acc.cpp ('k') | xfa/fxfa/app/xfa_ffchoicelist.cpp » ('j') | no next file with comments »