xfa/fxfa/app/xfa_ffchoicelist.cpp - Issue 2040503002: Fix more bugs found by /analyze tool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/app/xfa_ffchoicelist.cpp

Issue 2040503002: Fix more bugs found by /analyze tool (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: style fix Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/app/xfa_ffchoicelist.cpp

diff --git a/xfa/fxfa/app/xfa_ffchoicelist.cpp b/xfa/fxfa/app/xfa_ffchoicelist.cpp

index 51d693fa35d15ecf92ed70560e4113e4eb8d7042..4258eef29b72a2b381572ded638750eae53b0390 100644

--- a/xfa/fxfa/app/xfa_ffchoicelist.cpp

+++ b/xfa/fxfa/app/xfa_ffchoicelist.cpp

@@ -91,7 +91,7 @@ FX_BOOL CXFA_FFListBox::IsDataChanged() {

for (int32_t i = 0; i < iSels; ++i) {

IFWL_ListItem* hlistItem = pListBox->GetItem(iSelArray[i]);

- if (!(pListBox->GetItemStates(hlistItem) && FWL_ITEMSTATE_LTB_Selected))

+ if (!(pListBox->GetItemStates(hlistItem) & FWL_ITEMSTATE_LTB_Selected))

Tom Sepez 2016/06/03 18:54:37 Note: this was probably a real bug.

return TRUE;

}

return FALSE;

« xfa/fwl/core/cfwl_widgetmgr.cpp ('K') | « xfa/fwl/core/cfwl_widgetmgr.cpp ('k') | no next file » | no next file with comments »