Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: xfa/fxfa/app/xfa_ffchoicelist.cpp

Issue 2040503002: Fix more bugs found by /analyze tool (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fwl/core/cfwl_widgetmgr.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fxfa/app/xfa_ffchoicelist.h" 7 #include "xfa/fxfa/app/xfa_ffchoicelist.h"
8 8
9 #include "xfa/fwl/basewidget/ifwl_edit.h" 9 #include "xfa/fwl/basewidget/ifwl_edit.h"
10 #include "xfa/fwl/core/fwl_noteimp.h" 10 #include "xfa/fwl/core/fwl_noteimp.h"
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 CFX_Int32Array iSelArray; 84 CFX_Int32Array iSelArray;
85 m_pDataAcc->GetSelectedItems(iSelArray); 85 m_pDataAcc->GetSelectedItems(iSelArray);
86 int32_t iOldSels = iSelArray.GetSize(); 86 int32_t iOldSels = iSelArray.GetSize();
87 CFWL_ListBox* pListBox = (CFWL_ListBox*)m_pNormalWidget; 87 CFWL_ListBox* pListBox = (CFWL_ListBox*)m_pNormalWidget;
88 int32_t iSels = pListBox->CountSelItems(); 88 int32_t iSels = pListBox->CountSelItems();
89 if (iOldSels != iSels) 89 if (iOldSels != iSels)
90 return TRUE; 90 return TRUE;
91 91
92 for (int32_t i = 0; i < iSels; ++i) { 92 for (int32_t i = 0; i < iSels; ++i) {
93 IFWL_ListItem* hlistItem = pListBox->GetItem(iSelArray[i]); 93 IFWL_ListItem* hlistItem = pListBox->GetItem(iSelArray[i]);
94 if (!(pListBox->GetItemStates(hlistItem) && FWL_ITEMSTATE_LTB_Selected)) 94 if (!(pListBox->GetItemStates(hlistItem) & FWL_ITEMSTATE_LTB_Selected))
95 return TRUE; 95 return TRUE;
96 } 96 }
97 return FALSE; 97 return FALSE;
98 } 98 }
99 99
100 uint32_t CXFA_FFListBox::GetAlignment() { 100 uint32_t CXFA_FFListBox::GetAlignment() {
101 uint32_t dwExtendedStyle = 0; 101 uint32_t dwExtendedStyle = 0;
102 if (CXFA_Para para = m_pDataAcc->GetPara()) { 102 if (CXFA_Para para = m_pDataAcc->GetPara()) {
103 int32_t iHorz = para.GetHorizontalAlign(); 103 int32_t iHorz = para.GetHorizontalAlign();
104 switch (iHorz) { 104 switch (iHorz) {
(...skipping 418 matching lines...) Expand 10 before | Expand all | Expand 10 after
523 default: 523 default:
524 break; 524 break;
525 } 525 }
526 m_pOldDelegate->OnProcessEvent(pEvent); 526 m_pOldDelegate->OnProcessEvent(pEvent);
527 } 527 }
528 528
529 void CXFA_FFComboBox::OnDrawWidget(CFX_Graphics* pGraphics, 529 void CXFA_FFComboBox::OnDrawWidget(CFX_Graphics* pGraphics,
530 const CFX_Matrix* pMatrix) { 530 const CFX_Matrix* pMatrix) {
531 m_pOldDelegate->OnDrawWidget(pGraphics, pMatrix); 531 m_pOldDelegate->OnDrawWidget(pGraphics, pMatrix);
532 } 532 }
OLDNEW
« no previous file with comments | « xfa/fwl/core/cfwl_widgetmgr.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698