Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2318)

Unified Diff: chrome/browser/ui/webui/settings/settings_page_ui_handler.h

Issue 2040473002: Move {Resolve|Reject}JavascriptCallback helpers in WebUIMessageHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolvig conflicts with ToT Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/settings/settings_page_ui_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/settings/settings_page_ui_handler.h
diff --git a/chrome/browser/ui/webui/settings/settings_page_ui_handler.h b/chrome/browser/ui/webui/settings/settings_page_ui_handler.h
index b359130dd9df467c350b6b048981060b0af1d9bd..7007a7514242b9c9eac7a697a6e1a7b36b734397 100644
--- a/chrome/browser/ui/webui/settings/settings_page_ui_handler.h
+++ b/chrome/browser/ui/webui/settings/settings_page_ui_handler.h
@@ -17,19 +17,6 @@ class SettingsPageUIHandler : public content::WebUIMessageHandler {
SettingsPageUIHandler();
~SettingsPageUIHandler() override;
- protected:
- // Helper method for responding to JS requests initiated with
- // cr.sendWithPromise(), for the case where the returned promise should be
- // resolved (request succeeded).
- void ResolveJavascriptCallback(const base::Value& callback_id,
- const base::Value& response);
-
- // Helper method for responding to JS requests initiated with
- // cr.sendWithPromise(), for the case where the returned promise should be
- // rejected (request failed).
- void RejectJavascriptCallback(const base::Value& callback_id,
- const base::Value& response);
-
private:
// SettingsPageUIHandler subclasses must be JavaScript-lifecycle safe.
void OnJavascriptAllowed() override = 0;
« no previous file with comments | « no previous file | chrome/browser/ui/webui/settings/settings_page_ui_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698