Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Issue 2040463002: [css] Bandaid fix for crash when tables and containment mix. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/table/containment-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
index 6237eb1a2073860c7778461a5cf8e8c5cb6c6ca4..ccbc798b2cafd80305840e28aa170814681da2bb 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
@@ -793,7 +793,10 @@ void LayoutTableSection::layout()
{
ASSERT(needsLayout());
LayoutAnalyzer::Scope analyzer(*this);
- ASSERT(!needsCellRecalc());
+ // TODO(dgrogan): Change this to RELEASE_ASSERT(!needsCellRecalc()) once
+ // containment and tables play nicely. https://crbug.com/616643
+ if (needsCellRecalc())
+ return;
ASSERT(!table()->needsSectionRecalc());
// addChild may over-grow m_grid but we don't want to throw away the memory too early as addChild
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/table/containment-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698