views/mus: Create the BitmapUploader only when needed.

views/mus: Create the BitmapUploader only when needed.

BitmapUploader is needed only for chrome when it uses software rendering. So
instead of always creating a BitmapUploader (which creates an extra surface for
the window) for every widget, create it only when needed.

BUG=none

Committed: https://crrev.com/8e4d2a3ced7db1869346023b6f75b19fa9b74d38
Cr-Commit-Position: refs/heads/master@{#398069}

[sadrul, 2016-06-03 16:55:20]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-06-03 19:52:01]

https://codereview.chromium.org/2040453002/diff/20001/ui/views/mus/native_wid...
File ui/views/mus/native_widget_mus.cc (left):

https://codereview.chromium.org/2040453002/diff/20001/ui/views/mus/native_wid...
ui/views/mus/native_widget_mus.cc:504: if (!default_context_factory &&
connector) {
Why are you nuking the connector check? Tests may pass in null and I don't think
they want bitmapuploader.

[sadrul, 2016-06-03 22:16:40]

https://codereview.chromium.org/2040453002/diff/20001/ui/views/mus/native_wid...
File ui/views/mus/native_widget_mus.cc (left):

https://codereview.chromium.org/2040453002/diff/20001/ui/views/mus/native_wid...
ui/views/mus/native_widget_mus.cc:504: if (!default_context_factory &&
connector) {
On 2016/06/03 19:52:01, sky wrote:
> Why are you nuking the connector check? Tests may pass in null and I don't
think
> they want bitmapuploader.

I changed SurfaceBinding to be able to deal with null connector. If a test
passes in a null connector, they still get a SurfaceContextFactory (as long as
the test didn't install a ContextFactory on aura::Env), and bitmapuploader is
not used.

[sky, 2016-06-03 22:40:27]

I'm pretty sure the mash unittests install a contextfactory on
aura::Env. See
https://chromium.googlesource.com/chromium/src/+/master/mash/test/mash_test_s...
.

On Fri, Jun 3, 2016 at 3:16 PM,  <sadrul@chromium.org> wrote:
>
>
https://codereview.chromium.org/2040453002/diff/20001/ui/views/mus/native_wid...
> File ui/views/mus/native_widget_mus.cc (left):
>
>
https://codereview.chromium.org/2040453002/diff/20001/ui/views/mus/native_wid...
> ui/views/mus/native_widget_mus.cc:504: if (!default_context_factory &&
> connector) {
> On 2016/06/03 19:52:01, sky wrote:
>> Why are you nuking the connector check? Tests may pass in null and I
> don't think
>> they want bitmapuploader.
>
> I changed SurfaceBinding to be able to deal with null connector. If a
> test passes in a null connector, they still get a SurfaceContextFactory
> (as long as the test didn't install a ContextFactory on aura::Env), and
> bitmapuploader is not used.
>
> https://codereview.chromium.org/2040453002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sadrul, 2016-06-04 03:30:45]

On 2016/06/03 22:40:27, sky wrote:
> I'm pretty sure the mash unittests install a contextfactory on
> aura::Env. See
>
https://chromium.googlesource.com/chromium/src/+/master/mash/test/mash_test_s...

Yes. But this CL removes that code too.

[sky, 2016-06-06 17:00:46]

My mistake, LGTM

[sadrul, 2016-06-06 17:14:08]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-06-06 17:14:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040453002/20001

[commit-bot: I haz the power, 2016-06-06 18:23:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-06 18:25:51]

Description was changed from

==========
views/mus: Create the BitmapUploader only when needed.

BitmapUploader is needed only for chrome when it uses software rendering. So
instead of always creating a BitmapUploader (which creates an extra surface for
the window) for every widget, create it only when needed.

BUG=none
==========

to

==========
views/mus: Create the BitmapUploader only when needed.

BitmapUploader is needed only for chrome when it uses software rendering. So
instead of always creating a BitmapUploader (which creates an extra surface for
the window) for every widget, create it only when needed.

BUG=none

Committed: https://crrev.com/8e4d2a3ced7db1869346023b6f75b19fa9b74d38
Cr-Commit-Position: refs/heads/master@{#398069}
==========

[commit-bot: I haz the power, 2016-06-06 18:25:52]

Patchset 2 (id:??) landed as
https://crrev.com/8e4d2a3ced7db1869346023b6f75b19fa9b74d38
Cr-Commit-Position: refs/heads/master@{#398069}