Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2040433002: Fix undefined behavior in libpng (Closed)

Created:
4 years, 6 months ago by scroggo_chromium
Modified:
4 years, 6 months ago
Reviewers:
msarett, scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix undefined behavior in libpng Check for a null source before calling memcpy. BUG=skia:5390 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2040433002 Committed: https://skia.googlesource.com/skia/+/1915b0bab2b48cf8bf85dc49e76994b033f25450

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/libpng/README.google View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libpng/pngpread.c View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
scroggo
I figured the most expedient thing to do would be to fix the bug in ...
4 years, 6 months ago (2016-06-03 15:36:03 UTC) #3
msarett
Sounds good to me. lgtm
4 years, 6 months ago (2016-06-03 15:38:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2040433002/1
4 years, 6 months ago (2016-06-03 16:14:17 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 16:36:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1915b0bab2b48cf8bf85dc49e76994b033f25450

Powered by Google App Engine
This is Rietveld 408576698