Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 204043003: remove dead code from devtools worker management (Closed)

Created:
6 years, 9 months ago by alecflett
Modified:
6 years, 9 months ago
CC:
chromium-reviews, vsevik, jam, yurys, joi+watch-content_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman, horo
Visibility:
Public.

Description

remove dead code from devtools worker management BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -38 lines) Patch
M chrome/browser/devtools/devtools_target_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/devtools/devtools_target_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/devtools/worker_devtools_manager.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/devtools/worker_devtools_manager.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M content/public/browser/devtools_agent_host.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
alecflett
kaznacheev@ - I'm hooking up service workers, and found some dead code.. mind a quick ...
6 years, 9 months ago (2014-03-18 22:50:38 UTC) #1
Vladislav Kaznacheev
lgtm
6 years, 9 months ago (2014-03-19 14:09:33 UTC) #2
alecflett
The CQ bit was checked by alecflett@chromium.org
6 years, 9 months ago (2014-03-19 15:08:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/204043003/1
6 years, 9 months ago (2014-03-19 15:08:44 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 15:10:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-19 15:10:27 UTC) #6
alecflett
The CQ bit was checked by alecflett@chromium.org
6 years, 9 months ago (2014-03-19 18:22:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/204043003/1
6 years, 9 months ago (2014-03-19 18:22:28 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 18:52:41 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=56213
6 years, 9 months ago (2014-03-19 18:52:42 UTC) #10
alecflett
jam@ - easy review for more code removal?
6 years, 9 months ago (2014-03-19 19:27:18 UTC) #11
jam
lgtm
6 years, 9 months ago (2014-03-19 21:36:42 UTC) #12
alecflett
The CQ bit was checked by alecflett@chromium.org
6 years, 9 months ago (2014-03-19 22:08:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/204043003/1
6 years, 9 months ago (2014-03-19 22:10:16 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 05:48:53 UTC) #15
Message was sent while issue was closed. 
Change committed as 258204

Powered by Google App Engine
This is Rietveld 408576698