Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2040373006: Revert of [CacheStorage] Clean up CacheStorageCache lifetimes (Closed)

Created:
4 years, 6 months ago by jkarlin
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jkarlin+watch_chromium.org, nhiroki
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [CacheStorage] Clean up CacheStorageCache lifetimes (patchset #3 id:60001 of https://codereview.chromium.org/2040173002/ ) Reason for revert: Rather than carefully control the lifetimes of the refptrs, I'm going to give explicit ownership of caches to CacheStorage so that on ~CacheStorage the caches die. CacheStorage will give clients handles to the caches (that extend the lifetime but not past destruction). Original issue's description: > [CacheStorage] Clean up CacheStorageCache lifetimes > > CacheStorageCache refptrs are held in callbacks to cache operations, meaning that they won't be destructed > on profile shutdown. This CL moves the refptrs to member variables so that they will. > > BUG=617683 > > Committed: https://crrev.com/f9b13e0a9790f868a54ad4f3d1268d7369239ed4 > Cr-Commit-Position: refs/heads/master@{#398529} TBR=jochen@chromium.org,nhiroki@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=617683 Committed: https://crrev.com/ec7a87d4b4e2707ab7ad19a3125dbaed9cd2ad2a Cr-Commit-Position: refs/heads/master@{#398873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -107 lines) Patch
M content/browser/cache_storage/cache_storage.h View 6 chunks +5 lines, -7 lines 0 comments Download
M content/browser/cache_storage/cache_storage.cc View 11 chunks +33 lines, -46 lines 0 comments Download
M content/browser/cache_storage/cache_storage_cache.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/cache_storage/cache_storage_dispatcher_host.h View 2 chunks +8 lines, -7 lines 0 comments Download
M content/browser/cache_storage/cache_storage_dispatcher_host.cc View 10 chunks +19 lines, -25 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 3 chunks +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 3 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jkarlin
Created Revert of [CacheStorage] Clean up CacheStorageCache lifetimes
4 years, 6 months ago (2016-06-09 13:44:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040373006/1
4 years, 6 months ago (2016-06-09 13:44:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 14:33:19 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 14:33:26 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 14:35:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec7a87d4b4e2707ab7ad19a3125dbaed9cd2ad2a
Cr-Commit-Position: refs/heads/master@{#398873}

Powered by Google App Engine
This is Rietveld 408576698