Chromium Code Reviews
DescriptionRevert of [CacheStorage] Clean up CacheStorageCache lifetimes (patchset #3 id:60001 of https://codereview.chromium.org/2040173002/ )
Reason for revert:
Rather than carefully control the lifetimes of the refptrs, I'm going to give explicit ownership of caches to CacheStorage so that on ~CacheStorage the caches die. CacheStorage will give clients handles to the caches (that extend the lifetime but not past destruction).
Original issue's description:
> [CacheStorage] Clean up CacheStorageCache lifetimes
>
> CacheStorageCache refptrs are held in callbacks to cache operations, meaning that they won't be destructed
> on profile shutdown. This CL moves the refptrs to member variables so that they will.
>
> BUG=617683
>
> Committed: https://crrev.com/f9b13e0a9790f868a54ad4f3d1268d7369239ed4
> Cr-Commit-Position: refs/heads/master@{#398529}
TBR=jochen@chromium.org,nhiroki@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=617683
Committed: https://crrev.com/ec7a87d4b4e2707ab7ad19a3125dbaed9cd2ad2a
Cr-Commit-Position: refs/heads/master@{#398873}
Patch Set 1 #
Messages
Total messages: 7 (2 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||