Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2040373003: Set data availablity error. (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Set data availablity error. If we have been told we have a hint table, but fail to read the table, set the document status to error instead of just returning. BUG=pdfium:512 Committed: https://pdfium.googlesource.com/pdfium/+/bc58de0409636f64200b14097e4c781ace12422d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
dsinclair
PTAL. This allows pdfium_test to exit when opening the example from the bug.
4 years, 6 months ago (2016-06-08 20:01:41 UTC) #2
Tom Sepez
I wonder if this will cause real-world malformed PDFs to fail to load.
4 years, 6 months ago (2016-06-08 20:06:46 UTC) #3
dsinclair
On 2016/06/08 20:06:46, Tom Sepez wrote: > I wonder if this will cause real-world malformed ...
4 years, 6 months ago (2016-06-08 20:13:21 UTC) #4
Tom Sepez
On 2016/06/08 20:13:21, dsinclair wrote: > On 2016/06/08 20:06:46, Tom Sepez wrote: > > I ...
4 years, 6 months ago (2016-06-08 20:15:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040373003/1
4 years, 6 months ago (2016-06-08 20:16:23 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 20:17:59 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/bc58de0409636f64200b14097e4c781ace12...

Powered by Google App Engine
This is Rietveld 408576698