Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 2040363003: Always mark contextual ICs as 'recompute' (Closed)

Created:
4 years, 6 months ago by Toon Verwaest
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Always mark contextual ICs as 'recompute' Now that we track feedback per realm, this kind of IC is always guaranteed to be an update to the object structure. BUG= Committed: https://crrev.com/58f753bf33c2e02d37ce55e3e0be107a5ab90584 Cr-Commit-Position: refs/heads/master@{#36819}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M src/ic/ic.cc View 2 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ishell: ptal mvstanton: fyi
4 years, 6 months ago (2016-06-08 09:38:41 UTC) #2
Igor Sheludko
lgtm
4 years, 6 months ago (2016-06-08 09:44:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040363003/1
4 years, 6 months ago (2016-06-08 09:46:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 10:11:26 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 10:12:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58f753bf33c2e02d37ce55e3e0be107a5ab90584
Cr-Commit-Position: refs/heads/master@{#36819}

Powered by Google App Engine
This is Rietveld 408576698