Issue 204032: Remove valgrind filters for GTK unittests as the bots now run the tests with xvfb.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 204032: Remove valgrind filters for GTK unittests as the bots now run the tests with xvfb. (Closed)

Created:
11 years, 3 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, dank

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Remove valgrind filters for GTK unittests as the bots now run the tests with xvfb. BUG=15445 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26309

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	chrome/test/data/valgrind/unit_tests.gtest_linux.txt	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mattm

http://crbug.com/17590 made the tests run under xvfb-run. I got around to checking the bot stdout ...

11 years, 3 months ago (2009-09-16 00:12:22 UTC) #1

Lei Zhang

LGTM We can always revert if the valgrind bots turn red.

11 years, 3 months ago (2009-09-16 00:24:45 UTC) #2

not_the_right_dank

11 years, 3 months ago (2009-09-16 00:34:13 UTC) #3

LGTM

On Tue, Sep 15, 2009 at 5:12 PM,  <mattm@chromium.org> wrote:
>
> Reviewers: Lei Zhang, dank,
>
> Message:
> http://crbug.com/17590 made the tests run under xvfb-run.
>
> I got around to checking the bot stdout and it appears they are using
> runtest.py, so I guess that means the change is live.
>
> I did a local test of "xvfb-run tools/valgrind/chrome_tests.sh -t unit" w=
ith
> this change to verify there weren't any with-X leaks. =A0Other than that =
I
> can't
> think of other ways to verify this other than clean out the file and see
> what
> happens.
>
> Description:
> Remove valgrind filters for GTK unittests as the bots now run the tests w=
ith
> xvfb.
>
> BUG=3D15445
>
> Please review this at http://codereview.chromium.org/204032
>
> Affected files:
> =A0M chrome/test/data/valgrind/unit_tests.gtest_linux.txt
>
>
> Index: chrome/test/data/valgrind/unit_tests.gtest_linux.txt
> diff --git a/chrome/test/data/valgrind/unit_tests.gtest_linux.txt
> b/chrome/test/data/valgrind/unit_tests.gtest_linux.txt
> index
> 39360ae4b620704ebb9ddd2f979f771ac13e099f..e69de29bb2d1d6434b8b29ae775ad8c=
2e48c5391
> 100644
> --- a/chrome/test/data/valgrind/unit_tests.gtest_linux.txt
> +++ b/chrome/test/data/valgrind/unit_tests.gtest_linux.txt
> @@ -1,6 +0,0 @@
> -# See http://crbug.com/15445
> -# Only fails on the bots?
> -BookmarkEditorGtkTest.*
> -CookiesViewTest.*
> -LanguagesPageGtkTest.*
> -KeywordEditorViewTest.*
>
>
>

Expand Messages | Collapse Messages