[Third Party] Add sqlite4java to Chromium.

[Third Party] Add sqlite4java to Chromium.

These libraries are dependencies for Robolectric 3.0.

BUG=522043
Committed: https://crrev.com/014e84942446968c644e9a0f3da92f193b5a8cf7
Cr-Commit-Position: refs/heads/master@{#403346}

[mikecase (-- gone --), 2016-06-07 23:34:04]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org, yolandyan@chromium.org

[jbudorick, 2016-06-07 23:34:51]

Did you email chrome-eng-review for these?

[mikecase (-- gone --), 2016-06-08 00:25:24]

On 2016/06/07 at 23:34:51, jbudorick wrote:
> Did you email chrome-eng-review for these?

I assumed since Robolectric already exists in Chromium, and since these are for
updating Robolectric, I wouldn't need to go through eng-review?

[jbudorick, 2016-06-08 00:42:04]

On 2016/06/08 00:25:24, mikecase wrote:
> On 2016/06/07 at 23:34:51, jbudorick wrote:
> > Did you email chrome-eng-review for these?
> 
> I assumed since Robolectric already exists in Chromium, and since these are
for
> updating Robolectric, I wouldn't need to go through eng-review?

With the addition of a bunch of top-level third_party/ directories, it's
probably prudent to do so.

[mikecase (-- gone --), 2016-06-22 21:25:37]

mikecase@chromium.org changed reviewers:
+ klobag@chromium.org

[mikecase (-- gone --), 2016-06-22 21:25:38]

+klobag for third_party/ review

Got open-source approval via email.
Tested running "gclient runhooks" locally.

This is a dependency for Robolectric 3.0

[the real yoland, 2016-06-22 21:29:58]

lgtm

[the real yoland, 2016-06-22 21:32:26]

https://codereview.chromium.org/2040273003/diff/40001/third_party/sqlite4java...
File third_party/sqlite4java/BUILD.gn (right):

https://codereview.chromium.org/2040273003/diff/40001/third_party/sqlite4java...
third_party/sqlite4java/BUILD.gn:9: jar_path = "lib/sqlite4java-0.282.jar"
Comments on why linux, mac, window subdirectories and jar files are needed?

[mikecase (-- gone --), 2016-06-22 21:42:50]

https://codereview.chromium.org/2040273003/diff/40001/third_party/sqlite4java...
File third_party/sqlite4java/BUILD.gn (right):

https://codereview.chromium.org/2040273003/diff/40001/third_party/sqlite4java...
third_party/sqlite4java/BUILD.gn:10: }
Just fyi, the reason none of the .so/.dll/.jnilib are here in the build file is
kind of Robolectric specific. Robolectric look for these libraries in a very
specific path on the classpath.

See:
https://github.com/robolectric/robolectric/blob/master/robolectric-shadows/sh...

For example, it looks for "linux-x86/libsqlite4java.so" on the classpath. If I
recall, just having libsqlite4java.so on the classpath isn't sufficient; it has
to be in the specific directory robolectric is looking for it.

Two options: (1) Modify the Robolectric source code to look for the libraries
where GN adds them to the classpath. (2 [what I am doing now]) Package these
libraries in the Robolectric jar in the path Robolectric expects.

[jbudorick, 2016-06-27 13:31:17]

https://codereview.chromium.org/2040273003/diff/40001/third_party/sqlite4java...
File third_party/sqlite4java/BUILD.gn (right):

https://codereview.chromium.org/2040273003/diff/40001/third_party/sqlite4java...
third_party/sqlite4java/BUILD.gn:10: }
On 2016/06/22 21:42:50, mikecase wrote:
> Just fyi, the reason none of the .so/.dll/.jnilib are here in the build file
is
> kind of Robolectric specific. Robolectric look for these libraries in a very
> specific path on the classpath.
> 
> See:
>
https://github.com/robolectric/robolectric/blob/master/robolectric-shadows/sh...
> 
> For example, it looks for "linux-x86/libsqlite4java.so" on the classpath. If I
> recall, just having libsqlite4java.so on the classpath isn't sufficient; it
has
> to be in the specific directory robolectric is looking for it.
> 
> Two options: (1) Modify the Robolectric source code to look for the libraries
> where GN adds them to the classpath. (2 [what I am doing now]) Package these
> libraries in the Robolectric jar in the path Robolectric expects.

Can we do 2 in the short term w/ a plan of doing 1 in the long term? This seems
... pretty nasty.

[mikecase (-- gone --), 2016-06-27 17:17:31]

https://codereview.chromium.org/2040273003/diff/40001/third_party/sqlite4java...
File third_party/sqlite4java/BUILD.gn (right):

https://codereview.chromium.org/2040273003/diff/40001/third_party/sqlite4java...
third_party/sqlite4java/BUILD.gn:10: }
On 2016/06/27 at 13:31:17, jbudorick (EMEA til June 30) wrote:
> On 2016/06/22 21:42:50, mikecase wrote:
> > Just fyi, the reason none of the .so/.dll/.jnilib are here in the build file
is
> > kind of Robolectric specific. Robolectric look for these libraries in a very
> > specific path on the classpath.
> > 
> > See:
> >
https://github.com/robolectric/robolectric/blob/master/robolectric-shadows/sh...
> > 
> > For example, it looks for "linux-x86/libsqlite4java.so" on the classpath. If
I
> > recall, just having libsqlite4java.so on the classpath isn't sufficient; it
has
> > to be in the specific directory robolectric is looking for it.
> > 
> > Two options: (1) Modify the Robolectric source code to look for the
libraries
> > where GN adds them to the classpath. (2 [what I am doing now]) Package these
> > libraries in the Robolectric jar in the path Robolectric expects.
> 
> Can we do 2 in the short term w/ a plan of doing 1 in the long term? This
seems ... pretty nasty.

That sounds fine with me. There is another classpath related thing I want to fix
for Robolectric in chromium. That one being that the jars it loads at runtime
need to also have very specific names. It is why these targets....

https://cs.chromium.org/chromium/src/third_party/robolectric/BUILD.gn?sq=pack...

...have ugly names like "json-20080701" and "android-all-4.3_r2-robolectric-0".
This is so GN creates the jars with the names Robolectric expects. I'll work on
cleaning up both of these things once everything has landed.

[klobag.chromium, 2016-06-29 18:28:18]

lgtm

[jbudorick, 2016-06-30 08:12:08]

lgtm

[mikecase (-- gone --), 2016-06-30 22:43:59]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2016-06-30 22:44:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 23:45:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-30 23:45:41]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 23:47:49]

Description was changed from

==========
[Third Party] Add sqlite4java to Chromium.

These libraries are dependencies for Robolectric 3.0.

BUG=522043
==========

to

==========
[Third Party] Add sqlite4java to Chromium.

These libraries are dependencies for Robolectric 3.0.

BUG=522043

Committed: https://crrev.com/014e84942446968c644e9a0f3da92f193b5a8cf7
Cr-Commit-Position: refs/heads/master@{#403346}
==========

[commit-bot: I haz the power, 2016-06-30 23:47:50]

Patchset 3 (id:??) landed as
https://crrev.com/014e84942446968c644e9a0f3da92f193b5a8cf7
Cr-Commit-Position: refs/heads/master@{#403346}