Mac low power video: Support child windows, sheets, and transitions

Mac low power video: Support child windows, sheets, and transitions

We do not want to use the fullscreen low power window when we have
a child window, an active sheet, or we are in a fullscreen transition.

Add listeners for these changes, and make them call into the
FullscreenLowPowerCoordinatorCocoa.

Add two exceptions for child windows that were determined empirically
(toolbar and a 1x1 bubble).

Also update the fullscreen low power window to not be in the window
cycle or the window list.

BUG=594460
Committed: https://crrev.com/b1811073196ffed5ca106db948c5016dc2c2665b
Cr-Commit-Position: refs/heads/master@{#398425}

[ccameron, 2016-06-07 21:56:22]

ccameron@chromium.org changed reviewers:
+ spqchan@chromium.org

[ccameron, 2016-06-07 21:56:22]

ptal

[spqchan, 2016-06-07 22:30:32]

LGTM

Should there be tests for this?

https://codereview.chromium.org/2040253003/diff/1/chrome/browser/ui/cocoa/bro...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/2040253003/diff/1/chrome/browser/ui/cocoa/bro...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:766:
fullscreenLowPowerCoordinator_->SetInFullscreenTransition(false);
Why aren't we setting it to true in windowWillEnterFullscreen? Because
allowed_by_fullscreen_transition_ is false by default? Maybe add a comment about
it

[ccameron, 2016-06-07 23:12:50]

Thanks!

Added a comment about initial state.

I'm working on unittests for this -- I have a couple more scenarios that I want
to ensure are in their final state first (mostly about hysteresis).

https://codereview.chromium.org/2040253003/diff/1/chrome/browser/ui/cocoa/bro...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/2040253003/diff/1/chrome/browser/ui/cocoa/bro...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:766:
fullscreenLowPowerCoordinator_->SetInFullscreenTransition(false);
On 2016/06/07 22:30:32, spqchan wrote:
> Why aren't we setting it to true in windowWillEnterFullscreen? Because
> allowed_by_fullscreen_transition_ is false by default? Maybe add a comment
about
> it

Good point -- updated.

[ccameron, 2016-06-07 23:12:53]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-06-07 23:12:54]

The patchset sent to the CQ was uploaded after l-g-t-m from spqchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2040253003/#ps20001
(title: "Incorporate review feedback")

[commit-bot: I haz the power, 2016-06-07 23:13:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040253003/20001

[commit-bot: I haz the power, 2016-06-08 00:07:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-08 00:09:25]

Description was changed from

==========
Mac low power video: Support child windows, sheets, and transitions

We do not want to use the fullscreen low power window when we have
a child window, an active sheet, or we are in a fullscreen transition.

Add listeners for these changes, and make them call into the
FullscreenLowPowerCoordinatorCocoa.

Add two exceptions for child windows that were determined empirically
(toolbar and a 1x1 bubble).

Also update the fullscreen low power window to not be in the window
cycle or the window list.

BUG=594460
==========

to

==========
Mac low power video: Support child windows, sheets, and transitions

We do not want to use the fullscreen low power window when we have
a child window, an active sheet, or we are in a fullscreen transition.

Add listeners for these changes, and make them call into the
FullscreenLowPowerCoordinatorCocoa.

Add two exceptions for child windows that were determined empirically
(toolbar and a 1x1 bubble).

Also update the fullscreen low power window to not be in the window
cycle or the window list.

BUG=594460

Committed: https://crrev.com/b1811073196ffed5ca106db948c5016dc2c2665b
Cr-Commit-Position: refs/heads/master@{#398425}
==========

[commit-bot: I haz the power, 2016-06-08 00:09:25]

Patchset 2 (id:??) landed as
https://crrev.com/b1811073196ffed5ca106db948c5016dc2c2665b
Cr-Commit-Position: refs/heads/master@{#398425}

[ccameron, 2016-06-08 03:17:20]

Patchset #3 (id:40001) has been deleted