Implement sk_sp<SkImageFilter> StructTraits

Implement sk_sp<SkImageFilter> StructTraits

RenderPassDrawQuads need to be able to ship cc::FilterOperations which use
sk_sp<SkImageFilter>. This CL makes it possible to serialize and deserialize
them over mojo.

BUG=611802
Committed: https://crrev.com/567de3bea75fb0006ab1ca74be7f394473444ce5
Cr-Commit-Position: refs/heads/master@{#398379}

[Fady Samuel, 2016-06-07 15:34:48]

fsamuel@chromium.org changed reviewers:
+ reed@google.com, tsepez@chromium.org

[Fady Samuel, 2016-06-07 15:34:49]

+tsepez@ for security review
+reed@ for skia OWNER review

This CL makes it possible to serialize SkImageFilter over mojo.

[Tom Sepez, 2016-06-07 15:44:55]

https://codereview.chromium.org/2040233002/diff/1/skia/public/interfaces/imag...
File skia/public/interfaces/image_filter_struct_traits.h (right):

https://codereview.chromium.org/2040233002/diff/1/skia/public/interfaces/imag...
skia/public/interfaces/image_filter_struct_traits.h:46: SkFlattenable*
flattenable = SkValidatingDeserializeFlattenable(
Do you know if we are currently calling kValidatingDeserializeFlattenable() in
the receiving process, or does this introduce a new call path to validate?

Do we want to return false if the buffer isn't deserializable?

[Fady Samuel, 2016-06-07 17:40:53]

PTAL Tom, Mike! Thanks! :-)

https://codereview.chromium.org/2040233002/diff/1/skia/public/interfaces/imag...
File skia/public/interfaces/image_filter_struct_traits.h (right):

https://codereview.chromium.org/2040233002/diff/1/skia/public/interfaces/imag...
skia/public/interfaces/image_filter_struct_traits.h:46: SkFlattenable*
flattenable = SkValidatingDeserializeFlattenable(
On 2016/06/07 15:44:55, Tom Sepez wrote:
> Do you know if we are currently calling kValidatingDeserializeFlattenable() in
> the receiving process, or does this introduce a new call path to validate?
> 
> Do we want to return false if the buffer isn't deserializable?

We probably do! Done! Thanks!

[Tom Sepez, 2016-06-07 17:42:57]

Looks like this is already called in existing IPC-based ipc.  LGTM.

[Fady Samuel, 2016-06-07 18:40:55]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-07 18:41:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040233002/20001

[commit-bot: I haz the power, 2016-06-07 18:47:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 18:47:08]

Dry run: Try jobs failed on following builders:
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[reed1, 2016-06-07 19:06:20]

skia lgtm

[Fady Samuel, 2016-06-07 19:09:07]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-06-07 19:09:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040233002/20001

[Fady Samuel, 2016-06-07 19:40:24]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-06-07 19:40:24]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
reed@google.com
Link to the patchset: https://codereview.chromium.org/2040233002/#ps40001
(title: "Don't build StructTraitsTest on iOS")

[commit-bot: I haz the power, 2016-06-07 20:02:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040233002/40001

[commit-bot: I haz the power, 2016-06-07 21:35:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-07 21:37:45]

Description was changed from

==========
Implement sk_sp<SkImageFilter> StructTraits

RenderPassDrawQuads need to be able to ship cc::FilterOperations which use
sk_sp<SkImageFilter>. This CL makes it possible to serialize and deserialize
them over mojo.

BUG=611802
==========

to

==========
Implement sk_sp<SkImageFilter> StructTraits

RenderPassDrawQuads need to be able to ship cc::FilterOperations which use
sk_sp<SkImageFilter>. This CL makes it possible to serialize and deserialize
them over mojo.

BUG=611802

Committed: https://crrev.com/567de3bea75fb0006ab1ca74be7f394473444ce5
Cr-Commit-Position: refs/heads/master@{#398379}
==========

[commit-bot: I haz the power, 2016-06-07 21:37:46]

Patchset 3 (id:??) landed as
https://crrev.com/567de3bea75fb0006ab1ca74be7f394473444ce5
Cr-Commit-Position: refs/heads/master@{#398379}