Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2040193002: [stubs] Fixed tests that prevented LoadICTF stubs from being enabled. (Closed)

Created:
4 years, 6 months ago by Igor Sheludko
Modified:
4 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Fixed tests that prevented LoadICTF stubs from being enabled. PrimaryStubCache and SecondaryStubCache: resurrected outdated tests (and enabled stub cache counters in the new LoadIC). TryProbeStubCache: decreased number of code objects created. Committed: https://crrev.com/bcf3da279ff80f5276813e9529d248951b6ffa8a Cr-Commit-Position: refs/heads/master@{#36794}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -51 lines) Patch
M src/code-stub-assembler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 4 chunks +42 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +64 lines, -46 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040193002/1
4 years, 6 months ago (2016-06-07 13:31:16 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/2810)
4 years, 6 months ago (2016-06-07 13:42:28 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040193002/20001
4 years, 6 months ago (2016-06-07 13:51:56 UTC) #6
Igor Sheludko
PTAL
4 years, 6 months ago (2016-06-07 14:29:38 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-07 14:30:49 UTC) #11
Toon Verwaest
lgtm
4 years, 6 months ago (2016-06-07 14:53:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040193002/20001
4 years, 6 months ago (2016-06-07 15:01:18 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-07 15:04:26 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 15:04:58 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcf3da279ff80f5276813e9529d248951b6ffa8a
Cr-Commit-Position: refs/heads/master@{#36794}

Powered by Google App Engine
This is Rietveld 408576698