[CacheStorage] Clean up CacheStorageCache lifetimes

[CacheStorage] Clean up CacheStorageCache lifetimes

CacheStorageCache refptrs are held in callbacks to cache operations, meaning that they won't be destructed
on profile shutdown.  This CL moves the refptrs to member variables so that they will.

BUG=617683
Committed: https://crrev.com/f9b13e0a9790f868a54ad4f3d1268d7369239ed4
Cr-Commit-Position: refs/heads/master@{#398529}

[jkarlin, 2016-06-07 13:39:57]

jkarlin@chromium.org changed reviewers:
+ jochen@chromium.org, nhiroki@chromium.org

[jkarlin, 2016-06-07 13:39:58]

nhiroki: PTAL at everything
jochen: PTAL at content/browser/renderer_host/ for owners

Thanks!

[jochen (gone - plz use gerrit), 2016-06-07 19:11:22]

lgtm

[nhiroki, 2016-06-08 00:53:30]

lgtm

[jkarlin, 2016-06-08 10:34:12]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2016-06-08 10:34:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040173002/20001

[jkarlin, 2016-06-08 11:10:15]

The CQ bit was unchecked by jkarlin@chromium.org

[jkarlin, 2016-06-08 11:29:26]

Patchset #3 (id:40001) has been deleted

[jkarlin, 2016-06-08 12:35:20]

The CQ bit was checked by jkarlin@chromium.org

[jkarlin, 2016-06-08 12:35:20]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/2040173002/#ps60001
(title: "Simplify and caught one more reference")

[commit-bot: I haz the power, 2016-06-08 12:35:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040173002/60001

[commit-bot: I haz the power, 2016-06-08 12:40:05]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-06-08 12:41:37]

Description was changed from

==========
[CacheStorage] Clean up CacheStorageCache lifetimes

CacheStorageCache refptrs are held in callbacks to cache operations, meaning
that they won't be destructed
on profile shutdown.  This CL moves the refptrs to member variables so that they
will.

BUG=617683
==========

to

==========
[CacheStorage] Clean up CacheStorageCache lifetimes

CacheStorageCache refptrs are held in callbacks to cache operations, meaning
that they won't be destructed
on profile shutdown.  This CL moves the refptrs to member variables so that they
will.

BUG=617683

Committed: https://crrev.com/f9b13e0a9790f868a54ad4f3d1268d7369239ed4
Cr-Commit-Position: refs/heads/master@{#398529}
==========

[commit-bot: I haz the power, 2016-06-08 12:41:38]

Patchset 3 (id:??) landed as
https://crrev.com/f9b13e0a9790f868a54ad4f3d1268d7369239ed4
Cr-Commit-Position: refs/heads/master@{#398529}

[jkarlin, 2016-06-09 13:44:36]

A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2040373006/ by jkarlin@chromium.org.

The reason for reverting is: Rather than carefully control the lifetimes of the
refptrs, I'm going to give explicit ownership of caches to CacheStorage so that
on ~CacheStorage the caches die. CacheStorage will give clients handles to the
caches (that extend the lifetime but not past destruction)..