Issue 204015: Drag and drop for extension in RTL wasn't working properly....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 204015: Drag and drop for extension in RTL wasn't working properly.... (Closed)

Created:
11 years, 3 months ago by Nebojša Ćirić

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Drag and drop for extension in RTL wasn't working properly. ExtensionShelf::ToolstripAtX would never find a toolstrip for any value of x (or would find wrong one). BUG=11880 TEST=Load chrome with --lang=he, add 2-3 extensions and try dragging and switching their positions. It should work as LTR. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26188

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/views/extensions/extension_shelf.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages