Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2040143003: Revert of Strengthen GpuRasterizationConcavePathsPagetest test. (Closed)

Created:
4 years, 6 months ago by Geoff Lang
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, Stephen White
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Strengthen GpuRasterizationConcavePathsPagetest test. (patchset #1 id:1 of https://codereview.chromium.org/2042143002/ ) Reason for revert: Broke the GpuRasterization.ConcavePaths test on Nexus 9. https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Debug%20%28Nexus%209%29/builds/1470 Original issue's description: > Strengthen GpuRasterizationConcavePathsPagetest test. > > This test was passing when the entire 'pacman' image area was filled > with the 'interior' color. This change ensures that we test pixels on > the exterior and interior of the paths, within the pacman's bounds. > > R=kbr@chromium.org > BUG=617805 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/3b4f64f3c1564a04a688ea3fcefe3f5c4fe339fa > Cr-Commit-Position: refs/heads/master@{#398234} TBR=kbr@chromium.org,vmiura@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=617805 Committed: https://crrev.com/f11e62040635b57dccb826c1124ba53afc485792 Cr-Commit-Position: refs/heads/master@{#398317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M content/test/gpu/page_sets/gpu_rasterization_tests.py View 1 chunk +2 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Geoff Lang
Created Revert of Strengthen GpuRasterizationConcavePathsPagetest test.
4 years, 6 months ago (2016-06-07 17:09:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040143003/1
4 years, 6 months ago (2016-06-07 17:10:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 17:10:53 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f11e62040635b57dccb826c1124ba53afc485792 Cr-Commit-Position: refs/heads/master@{#398317}
4 years, 6 months ago (2016-06-07 17:11:58 UTC) #6
Ken Russell (switch to Gerrit)
4 years, 6 months ago (2016-06-07 17:38:07 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2046023002/ by kbr@chromium.org.

The reason for reverting is: The test is more correct than it was. Chrome on the
Nexus 9 is broken. Let's add a suppression instead of reverting the test.
.

Powered by Google App Engine
This is Rietveld 408576698