third_party/WebKit/Source/core/loader/FormSubmission.cpp - Issue 2040133003: Replace SecurityContext::InsecureRequestsPolicy with WebInsecureRequestPolicy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FormSubmission.cpp

Issue 2040133003: Replace SecurityContext::InsecureRequestsPolicy with WebInsecureRequestPolicy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@combine-uir-block

Patch Set: Ugh. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFormElement.cpp ('k') | third_party/WebKit/Source/core/loader/FrameFetchContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/FormSubmission.cpp

diff --git a/third_party/WebKit/Source/core/loader/FormSubmission.cpp b/third_party/WebKit/Source/core/loader/FormSubmission.cpp

index e66fa9eba1a541a5b91e5a9ac14bb03b67eecd9a..3d19b0fc6f2e7387b9496ff344fb37a40b639c51 100644

--- a/third_party/WebKit/Source/core/loader/FormSubmission.cpp

+++ b/third_party/WebKit/Source/core/loader/FormSubmission.cpp

@@ -45,6 +45,7 @@

#include "platform/heap/Handle.h"

#include "platform/network/EncodedFormData.h"

#include "platform/network/FormDataEncoder.h"

+#include "public/platform/WebInsecureRequestPolicy.h"

#include "wtf/CurrentTime.h"

#include "wtf/text/StringBuilder.h"

#include "wtf/text/TextEncoding.h"

@@ -198,7 +199,7 @@ FormSubmission* FormSubmission::create(HTMLFormElement* form, const Attributes&

Document& document = form->document();

KURL actionURL = document.completeURL(copiedAttributes.action().isEmpty() ? document.url().getString() : copiedAttributes.action());

- if (document.getInsecureRequestsPolicy() == SecurityContext::InsecureRequestsUpgrade && actionURL.protocolIs("http")) {

+ if (document.getInsecureRequestPolicy() & kUpgradeInsecureRequests && actionURL.protocolIs("http")) {

UseCounter::count(document, UseCounter::UpgradeInsecureRequestsUpgradedRequest);

actionURL.setProtocol("https");

if (actionURL.port() == 80)