Issue 204013009: my_activity.py: Parse rietveld dates without milliseconds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 204013009: my_activity.py: Parse rietveld dates without milliseconds. (Closed)

Created:
6 years, 9 months ago by deymo

Modified:
6 years, 9 months ago

Reviewers:
cmp, cjhopman, szager1

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

my_activity.py: Parse rietveld dates without milliseconds. Sometimes rietveld returns a datetime without the milliseconds part, presumably when it is 0. This patch fixes the parsing of those cases. BUG=chromium:323615 TEST=Ran "my_activity.py --week_of 11/18/13 --user jsbell" which returns "2013-11-18 20:42:30" for a bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=258189

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	my_activity.py	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deymo@chromium.org/204013009/1

6 years, 9 months ago (2014-03-20 01:54:22 UTC) #5

Message was sent while issue was closed.

Change committed as 258189

Expand Messages | Collapse Messages