Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 204013006: [webcrypto] Add length parameter to HmacKeyAlgorithm. (blink) (Closed)

Created:
6 years, 9 months ago by eroman
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

[webcrypto] Add length parameter to HmacKeyAlgorithm. (blink) Matches a planned change to the spec: https://www.w3.org/Bugs/Public/show_bug.cgi?id=25094 Chromium side of this change: https://codereview.chromium.org/203303006/ BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169567

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M LayoutTests/crypto/sign-verify.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/crypto/sign-verify-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/modules/crypto/HmacKeyAlgorithm.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/crypto/HmacKeyAlgorithm.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/modules/crypto/HmacKeyAlgorithm.idl View 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebCryptoKeyAlgorithmParams.h View 4 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
6 years, 9 months ago (2014-03-18 23:45:15 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-19 17:04:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/204013006/1
6 years, 9 months ago (2014-03-19 17:04:51 UTC) #3
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 18:14:46 UTC) #4
Message was sent while issue was closed.
Change committed as 169567

Powered by Google App Engine
This is Rietveld 408576698