Revert making apply_issue assume 'master'

Revert making apply_issue assume 'master'

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=257841

[agable, 2014-03-18 21:36:58]

Realized that the previous CL (https://codereview.chromium.org/202483008/)
actually breaks apply_issue for developers (but should be fine on all bots).
Since it enforces that self.remote_branch is always set, it will always create a
new working_brach tracking origin/master. This is not the desired behavior when
a developer is trying to apply a patch on top of their current local branch
(e.g. to merge someone else's work into their own).

This is a speculative revert. If any of the bots break (shouldn't happen) or we
think we need to revert the behavior for developers, I'll land this.

This CL does *not* revert the line that fixed the skiabuildbot CQ.

[M-A Ruel, 2014-03-19 00:55:22]

lgtm with optional nits

https://codereview.chromium.org/204013002/diff/1/apply_issue.py
File apply_issue.py (right):

https://codereview.chromium.org/204013002/diff/1/apply_issue.py#newcode165
apply_issue.py:165: base_ref=options.base_ref,)
I think I prefer the named arguments, since it's a lot of None...

Since it's really just remote_branch that you are changing, you could just
change this one.

Also, remove the extra comma.

[Ryan Tseng, 2014-03-19 02:35:56]

lgtm

I'll CQ this now because it does break (a very limited selection of) bots.

[commit-bot: I haz the power, 2014-03-19 02:35:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agable@chromium.org/204013002/1

[commit-bot: I haz the power, 2014-03-19 02:37:47]

Change committed as 257841