Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2040123002: SELECT popup: Fix a crash by DOM mutation during opening popup. (Closed)

Created:
4 years, 6 months ago by tkent
Modified:
4 years, 6 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SELECT popup: Fix a crash by DOM mutation during opening popup. A mutation callback can be called after MutationObserver is disconnected because MutationRecords are queued. BUG=617578 Committed: https://crrev.com/6d47f4e6911287f41bbad2f1456b19bc59b8d6fe Cr-Commit-Position: refs/heads/master@{#398244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/forms/select/menulist-popup-mutation-crash.html View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
tkent
Keishi, would you review this please?
4 years, 6 months ago (2016-06-07 04:10:59 UTC) #3
keishi
LGTM
4 years, 6 months ago (2016-06-07 04:24:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040123002/1
4 years, 6 months ago (2016-06-07 05:37:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 08:07:37 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 08:09:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d47f4e6911287f41bbad2f1456b19bc59b8d6fe
Cr-Commit-Position: refs/heads/master@{#398244}

Powered by Google App Engine
This is Rietveld 408576698