Use GetDebuggedContext instead of GetCallingContext in v8_inspector

third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/v8_inspector/InspectedContext.h"
 
 #include "platform/v8_inspector/InjectedScript.h"
 #include "platform/v8_inspector/V8Console.h"
 #include "platform/v8_inspector/V8DebuggerImpl.h"
 #include "platform/v8_inspector/V8StringUtil.h"
@@ skipping 56 matching lines @@
 v8::Isolate* InspectedContext::isolate() const
 {
     return m_debugger->isolate();
 }
 
 void InspectedContext::createInjectedScript()
 {
     DCHECK(!m_injectedScript);
     v8::HandleScope handles(isolate());
     v8::Local<v8::Context> localContext = context();
-    v8::Local<v8::Context> callingContext = isolate()->GetCallingContext();
-    if (!callingContext.IsEmpty() && !m_debugger->client()->callingContextCanAccessContext(callingContext, localContext))
+    v8::Local<v8::Context> callingContext;

[haraken, 2016/06/07 14:07:30]

Ditto.

+    if (!v8::Debug::GetDebuggedContext(isolate()).ToLocal(&callingContext))

[pfeldman, 2016/06/07 14:39:29]

We should not need calling context here - injected script is created in the
controlled code path, so we should be able to enter the context.

[jochen (gone - plz use gerrit), 2016/06/07 14:52:13]

so just delete this check?

[kozy, 2016/06/08 19:28:23]

I'm worried here about V8DebuggerAgent::currentCallFrames. In this call we
create related InjectedScript for each call frame in current stack on pause and
callingContext is top callFrame, targetContext is frame context. But if we are
able to call function from target context then it will be safe to create
InjectedScript in target context. If this case is safe then we can remove this
check.

[dgozman, 2016/06/09 08:53:45]

I think we'd better keep it for this call:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/v8_in...

This access checks are sanity checks anyway, since they originate from native
calls, and we only check the calling context, not the object being wrapped
"belonging" to the InjectedScript's context.

+        return;
+    if (!m_debugger->client()->callingContextCanAccessContext(callingContext, localContext))
         return;
     m_injectedScript = InjectedScript::create(this);
 }
 
 void InspectedContext::discardInjectedScript()
 {
     m_injectedScript.reset();
 }
 
 } // namespace blink