Use GetDebuggedContext instead of GetCallingContext in v8_inspector

third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 255 matching lines @@
     v8::HandleScope handles(m_context->isolate());
     V8FunctionCall function(m_context->debugger(), m_context->context(), v8Value(), "setCustomObjectFormatterEnabled");
     function.appendArgument(enabled);
     bool hadException = false;
     function.call(hadException);
     DCHECK(!hadException);
 }
 
 bool InjectedScript::canAccessInspectedWindow() const
 {
-    v8::Local<v8::Context> callingContext = m_context->isolate()->GetCallingContext();
-    if (callingContext.IsEmpty())
+    v8::Local<v8::Context> callingContext;

[haraken, 2016/06/07 14:07:30]

callingContext => debuggerContext ?

+    if (!v8::Debug::GetDebuggedContext(m_context->isolate()).ToLocal(&callingContext))

[dgozman, 2016/06/09 08:53:45]

Note that GetDebuggedContext says "while in debug context", which is not always
the case here - we may wrap some objects (e.g. DOM nodes) when not entered into
debugger context.

I don't see how implementation of GetDebuggedContext uses that fact though.
Should we change the comment?

         return true;
     return m_context->debugger()->client()->callingContextCanAccessContext(callingContext, m_context->context());
 }
 
 v8::Local<v8::Value> InjectedScript::v8Value() const
 {
     return m_value.Get(m_context->isolate());
 }
 
 v8::Local<v8::Value> InjectedScript::lastEvaluationResult() const
@@ skipping 230 matching lines @@
 void InjectedScript::CallFrameScope::findInjectedScript(V8InspectorSessionImpl* session)
 {
     std::unique_ptr<RemoteCallFrameId> remoteId = RemoteCallFrameId::parse(m_errorString, m_remoteCallFrameId);
     if (!remoteId)
         return;
     m_frameOrdinal = static_cast<size_t>(remoteId->frameOrdinal());
     m_injectedScript = session->findInjectedScript(m_errorString, remoteId.get());
 }
 
 } // namespace blink