Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2040053002: Switch the file-type pusher to invoke Ninja (Closed)

Created:
4 years, 6 months ago by Nathan Parker
Modified:
4 years, 6 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch the file-type pusher to invoke Ninja R=vakh BUG=616141 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/6a2842ec02fb283d1fa3da22a311f8b05d78c7c9 Cr-Commit-Position: refs/heads/master@{#398588}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -18 lines) Patch
M chrome/browser/resources/safe_browsing/README.md View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/resources/safe_browsing/push_file_type_proto.py View 1 chunk +28 lines, -11 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
Nathan Parker
4 years, 6 months ago (2016-06-06 20:28:02 UTC) #1
vakh (use Gerrit instead)
lgtm https://codereview.chromium.org/2040053002/diff/1/chrome/browser/resources/safe_browsing/push_file_type_proto.py File chrome/browser/resources/safe_browsing/push_file_type_proto.py (right): https://codereview.chromium.org/2040053002/diff/1/chrome/browser/resources/safe_browsing/push_file_type_proto.py#newcode27 chrome/browser/resources/safe_browsing/push_file_type_proto.py:27: 'such as ./out/Debug') `out-gn` to be consistent?
4 years, 6 months ago (2016-06-07 23:36:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040053002/1
4 years, 6 months ago (2016-06-08 15:25:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 16:19:23 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 16:20:56 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6a2842ec02fb283d1fa3da22a311f8b05d78c7c9
Cr-Commit-Position: refs/heads/master@{#398588}

Powered by Google App Engine
This is Rietveld 408576698