[Android] Revert the NDK back to r10e.

[Android] Revert the NDK back to r10e.

BUG=599327
Committed: https://crrev.com/e435da049c2b7f5d2302689be32a80f2424fd9d4
Cr-Commit-Position: refs/heads/master@{#398138}

[jbudorick, 2016-06-06 19:48:15]

jbudorick@chromium.org changed reviewers:
+ agrieve@chromium.org, twellington@chromium.org

[Theresa, 2016-06-06 19:58:10]

Does common.gypi need to change too?

[jbudorick, 2016-06-06 20:31:16]

On 2016/06/06 19:58:10, Theresa Wellington wrote:
> Does common.gypi need to change too?

For consistency, yes, though gyp is ~ dead for Android. Updated.

[Theresa, 2016-06-06 20:46:04]

lgtm

[jbudorick, 2016-06-06 20:46:40]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2016-06-06 20:48:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040043002/20001

[commit-bot: I haz the power, 2016-06-06 22:15:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-06 22:18:04]

Description was changed from

==========
[Android] Revert the NDK back to r10e.

BUG=599327
==========

to

==========
[Android] Revert the NDK back to r10e.

BUG=599327

Committed: https://crrev.com/e435da049c2b7f5d2302689be32a80f2424fd9d4
Cr-Commit-Position: refs/heads/master@{#398138}
==========

[commit-bot: I haz the power, 2016-06-06 22:18:05]

Patchset 2 (id:??) landed as
https://crrev.com/e435da049c2b7f5d2302689be32a80f2424fd9d4
Cr-Commit-Position: refs/heads/master@{#398138}

[Michael Achenbach, 2016-06-07 07:08:22]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2016-06-07 07:08:23]

https://codereview.chromium.org/2040043002/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/2040043002/diff/20001/build/common.gypi#newco...
build/common.gypi:1729: 'android_ndk_version%': 'r10e',
We might need a better mechanism in v8 for this. We have an auto-roller that
automatically pulls in the new android_tools, but it doesn't automatically
change this version variable in our standalone.gypi.

Clang has a similar mechanism for rebuilding, but the version isn't hardcoded in
a config file, but comes from the repo that rolled. Could we get something
similar here too? E.g. a small config file in android_tools that holds this
version, letting this variable here point to the content of that file. On each
roll the file could be edited.

Otherwise we get incremental build breakages on each android roll/revert (just
got one).

[jbudorick, 2016-06-07 12:59:58]

https://codereview.chromium.org/2040043002/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/2040043002/diff/20001/build/common.gypi#newco...
build/common.gypi:1729: 'android_ndk_version%': 'r10e',
On 2016/06/07 07:08:23, Michael Achenbach wrote:
> We might need a better mechanism in v8 for this. We have an auto-roller that
> automatically pulls in the new android_tools, but it doesn't automatically
> change this version variable in our standalone.gypi.
> 
> Clang has a similar mechanism for rebuilding, but the version isn't hardcoded
in
> a config file, but comes from the repo that rolled. Could we get something
> similar here too? E.g. a small config file in android_tools that holds this
> version, letting this variable here point to the content of that file. On each
> roll the file could be edited.
> 
> Otherwise we get incremental build breakages on each android roll/revert (just
> got one).

Sure, I'll do something like that before the next roll.