Issue 204003004: Re-enable networkState_during_progress.html but mark as flaky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 204003004: Re-enable networkState_during_progress.html but mark as flaky. (Closed)

Created:
6 years, 9 months ago by ddorwin

Modified:
6 years, 9 months ago

Reviewers:
philipj_slow

CC:
blink-reviews, feature-media-reviews_chromium.org, eric.carlson_apple.com

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Re-enable networkState_during_progress.html but mark as flaky. This CL also fixes the -expected file with the correct expectations (PASS), though this test rarely passes. As noted in the bug, the test has been confirmed correct, and we need to fix our behavior. At that time, we can remove the TestExpectations entry. BUG=306249 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169521

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	LayoutTests/TestExpectations	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	LayoutTests/media/W3C/video/networkState/networkState_during_progress-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ddorwin@chromium.org/204003004/1

6 years, 9 months ago (2014-03-19 03:46:59 UTC) #4

philipj_slow

Oops, I didn't know that LayoutTests/OWNERS was *, I should be careful with non-owner reviews ...

6 years, 9 months ago (2014-03-19 03:59:12 UTC) #5

Message was sent while issue was closed.

Change committed as 169521

Expand Messages | Collapse Messages