DescriptionRevert of mac: ensure ui::Compositor exists for visible RWHVs (patchset #12 id:220001 of https://codereview.chromium.org/2005013002/ )
Reason for revert:
Causes blank tabs, tab switching perf tests
BUG=617497, 617427
Original issue's description:
> mac: ensure ui::Compositor exists for visible RWHVs
>
> RenderWidgetHostViewMac is careful about creating ui::Compositor and so
> currently only does this in Show and SwapCompositorFrame. However, if
> it the RenderWidgetHostView is created while the RenderWidgetHost is
> visible, then Show will early out and never create a ui::Compositor.
>
> This causes problems with begin frame scheduling, which wants to have
> the Display (which is created as part of creating the ui::Compositor's
> output surface currently) own the real begin frame source that drives
> everything. In that world, if no ui::Compositor exists, no frames ever
> are sent or swapped. So, the ui::Compositor needs to be created first.
>
> Also, if the ui::Compositor is correctly created during Show (or the
> constructor), then there's no need to ensure that it exists during
> swap compositor frame, and so that can be safely removed.
>
> R=asvitkine@chromium.org,ccameron@chromium.org
>
> Committed: https://crrev.com/9af6c23da7070f9423d5cf25856ed27f7d5d8e5e
> Cr-Commit-Position: refs/heads/master@{#397755}
TBR=phajdan.jr@chromium.org,asvitkine@chromium.org,ccameron@chromium.org,danakj@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
Committed: https://crrev.com/d5d349f0ff52e0a478ae9b807d35c0511e828fa5
Cr-Commit-Position: refs/heads/master@{#398144}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|