third_party/WebKit/Source/core/frame/ImageBitmap.h - Issue 2039983002: Change code path for structured cloning ImageBitmap

Unified Diff: third_party/WebKit/Source/core/frame/ImageBitmap.h

Issue 2039983002: Change code path for structured cloning ImageBitmap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp ('k') | third_party/WebKit/Source/core/frame/ImageBitmap.cpp » ('j') | third_party/WebKit/Source/core/frame/ImageBitmap.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/ImageBitmap.h

diff --git a/third_party/WebKit/Source/core/frame/ImageBitmap.h b/third_party/WebKit/Source/core/frame/ImageBitmap.h

index 1e6e3db9db56924decb8f44f2124148eb065a267..3b7f1a5b33149c7b4ecc88406ed19b91cff8f493 100644

--- a/third_party/WebKit/Source/core/frame/ImageBitmap.h

+++ b/third_party/WebKit/Source/core/frame/ImageBitmap.h

@@ -37,7 +37,7 @@ public:

static ImageBitmap* create(HTMLImageElement*, const IntRect&, Document*, const ImageBitmapOptions& = ImageBitmapOptions());

static ImageBitmap* create(HTMLVideoElement*, const IntRect&, Document*, const ImageBitmapOptions& = ImageBitmapOptions());

static ImageBitmap* create(HTMLCanvasElement*, const IntRect&, const ImageBitmapOptions& = ImageBitmapOptions());

- static ImageBitmap* create(ImageData*, const IntRect&, const ImageBitmapOptions& = ImageBitmapOptions(), const bool& isImageDataPremultiplied = false, const bool& isImageDataOriginClean = true);

+ static ImageBitmap* create(ImageData*, const IntRect&, const ImageBitmapOptions& = ImageBitmapOptions(), const bool& isImageDataOriginClean = true);

jbroman 2016/06/27 19:16:16 nit: not new here, but booleans should just be pas

xidachen 2016/06/27 19:48:22 Done.

static ImageBitmap* create(ImageBitmap*, const IntRect&, const ImageBitmapOptions& = ImageBitmapOptions());

static ImageBitmap* create(PassRefPtr<StaticBitmapImage>);

static ImageBitmap* create(PassRefPtr<StaticBitmapImage>, const IntRect&, const ImageBitmapOptions& = ImageBitmapOptions());

@@ -82,7 +82,7 @@ private:

ImageBitmap(HTMLImageElement*, const IntRect&, Document*, const ImageBitmapOptions&);

ImageBitmap(HTMLVideoElement*, const IntRect&, Document*, const ImageBitmapOptions&);

ImageBitmap(HTMLCanvasElement*, const IntRect&, const ImageBitmapOptions&);

- ImageBitmap(ImageData*, const IntRect&, const ImageBitmapOptions&, const bool&, const bool&);

+ ImageBitmap(ImageData*, const IntRect&, const ImageBitmapOptions&, const bool&);

ImageBitmap(ImageBitmap*, const IntRect&, const ImageBitmapOptions&);

ImageBitmap(PassRefPtr<StaticBitmapImage>);

ImageBitmap(PassRefPtr<StaticBitmapImage>, const IntRect&, const ImageBitmapOptions&);