third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h - Issue 2039983002: Change code path for structured cloning ImageBitmap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h

Issue 2039983002: Change code path for structured cloning ImageBitmap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/canvas-ImageBitmap-structured-clone.html ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp » ('j') | third_party/WebKit/Source/core/frame/ImageBitmap.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h b/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h

index 84c8b69535c763cb181eca2af1d077b5c2062de1..c120eeff98f391c92a7f3e513abac88d82667498 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h

@@ -142,7 +142,7 @@ protected:

void writeArrayBufferView(const DOMArrayBufferView&);

void doWriteImageData(uint32_t width, uint32_t height, const uint8_t* pixelData, uint32_t pixelDataLength);

void writeImageData(uint32_t width, uint32_t height, const uint8_t* pixelData, uint32_t pixelDataLength);

- void writeImageBitmap(uint32_t width, uint32_t height, uint32_t isOriginClean, const uint8_t* pixelData, uint32_t pixelDataLength);

+ void writeImageBitmap(uint32_t width, uint32_t height, uint32_t isOriginClean, uint32_t isPremultiplied, const uint8_t* pixelData, uint32_t pixelDataLength);

void writeRegExp(v8::Local<v8::String> pattern, v8::RegExp::Flags);

void writeTransferredMessagePort(uint32_t index);

void writeTransferredArrayBuffer(uint32_t index);

@@ -509,7 +509,7 @@ private:

bool readDate(v8::Local<v8::Value>*);

bool readNumber(v8::Local<v8::Value>*);

bool readNumberObject(v8::Local<v8::Value>*);

- ImageData* doReadImageData();

+ bool doReadImageDataProperties(uint32_t*, uint32_t*, uint32_t*);

jbroman 2016/06/29 18:03:53 Please name parameters here as well; it's not obvi

bool readImageData(v8::Local<v8::Value>*);

bool readImageBitmap(v8::Local<v8::Value>*);

bool readCompositorProxy(v8::Local<v8::Value>*);