Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2039943002: [Cronet] Send request headers automatically in bidirectional stream on iOS. (Closed)

Created:
4 years, 6 months ago by mef
Modified:
4 years, 6 months ago
Reviewers:
kapishnikov, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Send request headers automatically in bidirectional stream on iOS. BUG=599902 Committed: https://crrev.com/a3fef780c8c8e050a37ecc7175c92bffc30d38fa Cr-Commit-Position: refs/heads/master@{#398045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/cronet/ios/cronet_bidirectional_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
mef
PTAL, a small change to fix Cronet Bidirectional Stream on iOS broken by change of ...
4 years, 6 months ago (2016-06-06 15:35:25 UTC) #2
xunjieli
lgtm
4 years, 6 months ago (2016-06-06 15:38:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039943002/1
4 years, 6 months ago (2016-06-06 15:44:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 16:25:23 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a3fef780c8c8e050a37ecc7175c92bffc30d38fa Cr-Commit-Position: refs/heads/master@{#398045}
4 years, 6 months ago (2016-06-06 16:29:02 UTC) #8
xunjieli
Thanks for the fix. Sorry that I didn't notice this earlier. Do we need this ...
4 years, 6 months ago (2016-06-06 16:54:17 UTC) #9
mef
4 years, 6 months ago (2016-06-06 16:59:27 UTC) #10
Message was sent while issue was closed.
On 2016/06/06 16:54:17, xunjieli wrote:
> Thanks for the fix. Sorry that I didn't notice this earlier. 
> Do we need this merged into M52 as well?

Hrm, I suppose we do for a good measure.

Powered by Google App Engine
This is Rietveld 408576698