hide Config8888 entirely

src/core/SkBitmapDevice.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkBitmapDevice.h"
 #include "SkConfig8888.h"
 #include "SkDraw.h"
@@ skipping 203 matching lines @@
                         int rowCount) {
     SkASSERT(bytesPerRow <= srcRB);
     SkASSERT(bytesPerRow <= dstRB);
     for (int i = 0; i < rowCount; ++i) {
         memcpy(dst, src, bytesPerRow);
         dst = (char*)dst + dstRB;
         src = (const char*)src + srcRB;
     }
 }
 
-static bool info2config8888(const SkImageInfo& info, SkCanvas::Config8888* config) {
-    bool pre;
-    switch (info.alphaType()) {
-        case kPremul_SkAlphaType:
-        case kOpaque_SkAlphaType:
-            pre = true;
-            break;
-        case kUnpremul_SkAlphaType:
-            pre = false;
-            break;
-        default:
-            return false;
-    }
-    switch (info.colorType()) {
-        case kRGBA_8888_SkColorType:
-            *config = pre ? SkCanvas::kRGBA_Premul_Config8888 : SkCanvas::kRGBA_Unpremul_Config8888;
-            return true;
-        case kBGRA_8888_SkColorType:
-            *config = pre ? SkCanvas::kBGRA_Premul_Config8888 : SkCanvas::kBGRA_Unpremul_Config8888;
-            return true;
-        default:
-            return false;
-    }
-}
+#include "SkConfig8888.h"
 
-// TODO: make this guy real, and not rely on legacy config8888 utility
-#include "SkConfig8888.h"
 static bool copy_pixels(const SkImageInfo& dstInfo, void* dstPixels, size_t dstRowBytes,
                         const SkImageInfo& srcInfo, const void* srcPixels, size_t srcRowBytes) {
     if (srcInfo.dimensions() != dstInfo.dimensions()) {
         return false;
     }
     if (4 == srcInfo.bytesPerPixel() && 4 == dstInfo.bytesPerPixel()) {
-        SkCanvas::Config8888 srcConfig, dstConfig;
-        if (!info2config8888(srcInfo, &srcConfig) || !info2config8888(dstInfo, &dstConfig)) {
-            return false;
-        }
-        SkConvertConfig8888Pixels((uint32_t*)dstPixels, dstRowBytes, dstConfig,
-                                  (const uint32_t*)srcPixels, srcRowBytes, srcConfig,
-                                  srcInfo.width(), srcInfo.height());
-        return true;
+        SkDstPixelInfo dstPI;
+        dstPI.fColorType = dstInfo.colorType();
+        dstPI.fAlphaType = dstInfo.alphaType();
+        dstPI.fPixels = dstPixels;
+        dstPI.fRowBytes = dstRowBytes;
+
+        SkSrcPixelInfo srcPI;
+        srcPI.fColorType = srcInfo.colorType();
+        srcPI.fAlphaType = srcInfo.alphaType();
+        srcPI.fPixels = srcPixels;
+        srcPI.fRowBytes = srcRowBytes;
+
+        return srcPI.convertPixelsTo(&dstPI, srcInfo.width(), srcInfo.height());
     }
     if (srcInfo.colorType() == dstInfo.colorType()) {
         switch (srcInfo.colorType()) {
             case kRGB_565_SkColorType:
             case kAlpha_8_SkColorType:
                 break;
             case kARGB_4444_SkColorType:
                 if (srcInfo.alphaType() != dstInfo.alphaType()) {
                     return false;
                 }
@@ skipping 264 matching lines @@
         paint.getStyle() != SkPaint::kFill_Style ||
         !SkXfermode::IsMode(paint.getXfermode(), SkXfermode::kSrcOver_Mode)) {
         // turn off lcd
         flags->fFlags = paint.getFlags() & ~SkPaint::kLCDRenderText_Flag;
         flags->fHinting = paint.getHinting();
         return true;
     }
     // we're cool with the paint as is
     return false;
 }