Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2039923003: Remove suppressions for bug 258479 (races in SamplingStateScope::set()) (Closed)

Created:
4 years, 6 months ago by Alexander Potapenko
Modified:
4 years, 6 months ago
Reviewers:
tommycli
CC:
chromium-reviews, cbiesinger
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove suppressions for bug 258479 (races in SamplingStateScope::set()) BUG=258479 TBR=tommycli@chromium.org Committed: https://crrev.com/8ce4772a273e2f594c9c1410211caf2dcae3446f Cr-Commit-Position: refs/heads/master@{#398515}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Alexander Potapenko
TBR
4 years, 6 months ago (2016-06-07 13:43:14 UTC) #1
cbiesinger
I'm not the right person to review this
4 years, 6 months ago (2016-06-07 15:22:12 UTC) #2
Alexander Potapenko
On 2016/06/07 15:22:12, cbiesinger wrote: > I'm not the right person to review this Ok.
4 years, 6 months ago (2016-06-08 09:30:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039923003/1
4 years, 6 months ago (2016-06-08 09:32:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 10:17:02 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8ce4772a273e2f594c9c1410211caf2dcae3446f Cr-Commit-Position: refs/heads/master@{#398515}
4 years, 6 months ago (2016-06-08 10:19:39 UTC) #11
Alexander Potapenko
4 years, 6 months ago (2016-06-08 12:12:14 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2046953003/ by glider@chromium.org.

The reason for reverting is: The bug hasn't actually been fixed..

Powered by Google App Engine
This is Rietveld 408576698