Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2039923002: Fix the .ycm_extra_conf.py and SublimeText documentation. (Closed)

Created:
4 years, 6 months ago by pastarmovj
Modified:
4 years, 6 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the .ycm_extra_conf.py and SublimeText documentation. There were a few broken links in the documentation and the provided YCM template would not load properly in Sublime Text 3 on windows. Lastly make the unit presubmit test pass on Windows too. BUG=NONE TEST=chromium.ycm_extra_conf_unittest.py Committed: https://crrev.com/7e3be85fc10b1d0f44c5e7f5f87382aa39e9469b Cr-Commit-Position: refs/heads/master@{#398330}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reverted a forgotten debug hack. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -22 lines) Patch
M docs/linux_sublime_dev.md View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/vim/chromium.ycm_extra_conf.py View 3 chunks +6 lines, -5 lines 0 comments Download
M tools/vim/tests/chromium.ycm_extra_conf_unittest.py View 1 4 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
pastarmovj
Hello, In the spirit of the fixit month and while setting up my new Windows ...
4 years, 6 months ago (2016-06-06 14:17:22 UTC) #2
scottmg
https://codereview.chromium.org/2039923002/diff/1/tools/vim/tests/chromium.ycm_extra_conf_unittest.py File tools/vim/tests/chromium.ycm_extra_conf_unittest.py (right): https://codereview.chromium.org/2039923002/diff/1/tools/vim/tests/chromium.ycm_extra_conf_unittest.py#newcode115 tools/vim/tests/chromium.ycm_extra_conf_unittest.py:115: if False and self.test_root: ?
4 years, 6 months ago (2016-06-06 16:32:11 UTC) #3
pastarmovj
Sorry for the forgetting this hack in. https://codereview.chromium.org/2039923002/diff/1/tools/vim/tests/chromium.ycm_extra_conf_unittest.py File tools/vim/tests/chromium.ycm_extra_conf_unittest.py (right): https://codereview.chromium.org/2039923002/diff/1/tools/vim/tests/chromium.ycm_extra_conf_unittest.py#newcode115 tools/vim/tests/chromium.ycm_extra_conf_unittest.py:115: if False ...
4 years, 6 months ago (2016-06-07 08:52:29 UTC) #4
scottmg
lgtm
4 years, 6 months ago (2016-06-07 15:00:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039923002/20001
4 years, 6 months ago (2016-06-07 15:04:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-07 17:54:10 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 17:55:46 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7e3be85fc10b1d0f44c5e7f5f87382aa39e9469b
Cr-Commit-Position: refs/heads/master@{#398330}

Powered by Google App Engine
This is Rietveld 408576698