Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2039913007: Fix mipmap generation on Nexus 5x & 6p devices. (Closed)

Created:
4 years, 6 months ago by Brian Osman
Modified:
4 years, 6 months ago
Reviewers:
jvanverth1, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix mipmap generation on Nexus 5x & 6p devices. Just like copyImage, these want the Z range of blit regions to be [0, 1], even for 2D resources where Z should be ignored. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2039913007 Committed: https://skia.googlesource.com/skia/+/e9906e71fbc29968ea10680f0fcd53a4153c7568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/gpu/vk/GrVkGpu.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039913007/1
4 years, 6 months ago (2016-06-08 19:06:59 UTC) #3
Brian Osman
4 years, 6 months ago (2016-06-08 19:07:10 UTC) #5
egdaniel
lgtm, but maybe add some shorten form of the CopyImage comment so we know why ...
4 years, 6 months ago (2016-06-08 19:10:29 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-08 19:25:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039913007/1
4 years, 6 months ago (2016-06-08 19:43:31 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 19:44:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e9906e71fbc29968ea10680f0fcd53a4153c7568

Powered by Google App Engine
This is Rietveld 408576698