runtime/vm/flow_graph_compiler_dbc.cc - Issue 2039913006: DBC: Eager deoptimization and CheckSmi instruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_dbc.cc

Issue 2039913006: DBC: Eager deoptimization and CheckSmi instruction. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_dbc.cc

diff --git a/runtime/vm/flow_graph_compiler_dbc.cc b/runtime/vm/flow_graph_compiler_dbc.cc

index 86352cc491b03df24cef4cc6c6dc978111bb8f21..eae97e28972bb29ceacca4dd182ffd970cd70563 100644

--- a/runtime/vm/flow_graph_compiler_dbc.cc

+++ b/runtime/vm/flow_graph_compiler_dbc.cc

@@ -209,7 +209,7 @@ void FlowGraphCompiler::RecordAfterCall(Instruction* instr) {

void CompilerDeoptInfoWithStub::GenerateCode(FlowGraphCompiler* compiler,

intptr_t stub_ix) {

- UNIMPLEMENTED();

+ UNREACHABLE();

}

« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/instructions_dbc.cc » ('j') | no next file with comments »