Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Unified Diff: runtime/vm/constants_dbc.h

Issue 2039913006: DBC: Eager deoptimization and CheckSmi instruction. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_dbc_test.cc ('k') | runtime/vm/deopt_instructions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/constants_dbc.h
diff --git a/runtime/vm/constants_dbc.h b/runtime/vm/constants_dbc.h
index 4449cb1d0c33607d10293e7f2d8b548798112a8b..1518bfa097e659a4936eea4e0d5ba790302491cc 100644
--- a/runtime/vm/constants_dbc.h
+++ b/runtime/vm/constants_dbc.h
@@ -323,6 +323,10 @@ namespace dart {
//
// Assert that TOS is a boolean (A = 1) or that TOS is not null (A = 0).
//
+// - CheckSmi rA
+//
+// If FP[rA] is a Smi, then skip the next instruction.
+//
// - CheckStack
//
// Compare SP against isolate stack limit and call StackOverflow handler if
@@ -359,7 +363,7 @@ namespace dart {
// e.g. in bytecode sequences like
//
// InstanceCall ... <- lazy deopt inside first call
-// InstanceCall ... <- patches seconds call with Deopt
+// InstanceCall ... <- patches second call with Deopt
//
// BYTECODE LIST FORMAT
//
@@ -453,6 +457,7 @@ namespace dart {
V(InstantiateTypeArgumentsTOS, A_D, num, lit, ___) \
V(AssertAssignable, D, num, lit, ___) \
V(AssertBoolean, A, num, ___, ___) \
+ V(CheckSmi, A, reg, ___, ___) \
V(CheckStack, 0, ___, ___, ___) \
V(DebugStep, 0, ___, ___, ___) \
V(DebugBreak, A, num, ___, ___) \
« no previous file with comments | « runtime/vm/assembler_dbc_test.cc ('k') | runtime/vm/deopt_instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698